From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B97B4C433DF for ; Mon, 18 May 2020 10:11:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99D0920853 for ; Mon, 18 May 2020 10:11:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WfGl7ijc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726828AbgERKLO (ORCPT ); Mon, 18 May 2020 06:11:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726302AbgERKLO (ORCPT ); Mon, 18 May 2020 06:11:14 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 494D7C05BD0C for ; Mon, 18 May 2020 03:11:13 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id n11so4585286pgl.9 for ; Mon, 18 May 2020 03:11:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rcBjffi4kQszuwFLOMY+Y6F9ZFkZd22+sdJvlsBdEYg=; b=WfGl7ijczvb4fyfsojKm6/aNFhV2eCeaQfVNvf5pSUzoQrH5gSc0teZbBMAQD3ifY6 8Xq7ffvVEKShSI+Y5D6o9r0g4UEiy/7PCijWdtr59qtwztnsYfjZ5zofrHUdFMsVo4Wu gSqS7ohq6M+QiRNe9MEQAsXtzQ33VBfpwAWKjDh13NM7wmhqm6nDAMFd92NTn3M2oxyH vFeI0ylamQfCiWz4KTU1D+PRZrO2D05P7U2Ob+lSoLnkZGe52tqGlEdhsmpwgIjuGZ85 A9JQgrwsUjTvNUgvG25pqMn39fsOoK5hetlUU0Iou4d+M5xy9u68+T0U2Bd2+2LLitfF p2IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rcBjffi4kQszuwFLOMY+Y6F9ZFkZd22+sdJvlsBdEYg=; b=CrX9atShxCp7op30H1URpIiSgylbqHOCNHeC76rWRYOgESTU6s68mzXXCQVqQJUHqI AFbNyUE4GPqAavrPwCLUaruu4znLVDFfRCCF2S8P31cLYd/3Twyb8V4Vu+XIJfMJ3Lmb 1f5VCsXDCCUEuid/5G1iPXoUwUSoN1Kn7K/Ejr4Q0T9LA2EGbGHkQfCuUGn+yklIqbHE 83zPu2CzWIf5oxRqePT3ke0EQOeCxGINpyoIV7yXRxuJoUwW8tKXC08wnZgiPPGGxJ3p 0JYT/64mUeR09PfNP1Q38rHq0jE/e9/GUs9nNpkvrq2BPsR8F4IJUuloZApdkz4hWMmy 2vHA== X-Gm-Message-State: AOAM532UHX6FSxuWCoeXyhPtD7W0IBYChkal2kQE45AaWkImVpm/gE1C gXv4Fw8PURPrC5nqcrdP21mV7g== X-Google-Smtp-Source: ABdhPJzWkRCIO7jgNHpcV82IrfsERhQCBZdR7cCDWFIWDzouKNaN0H/xiCZ6R3hSQValouNWNaYbJA== X-Received: by 2002:a62:79c2:: with SMTP id u185mr1949116pfc.159.1589796672606; Mon, 18 May 2020 03:11:12 -0700 (PDT) Received: from localhost ([122.167.130.103]) by smtp.gmail.com with ESMTPSA id y22sm2305167pfc.132.2020.05.18.03.11.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 May 2020 03:11:11 -0700 (PDT) Date: Mon, 18 May 2020 15:41:09 +0530 From: Viresh Kumar To: "Rafael J. Wysocki" Cc: Serge Semin , Serge Semin , Thomas Bogendoerfer , "Rafael J. Wysocki" , Ulf Hansson , Matthias Kaehlcke , Alexey Malahov , Paul Burton , Ralf Baechle , Arnd Bergmann , Rob Herring , linux-mips@vger.kernel.org, devicetree@vger.kernel.org, stable@vger.kernel.org, Frederic Weisbecker , Ingo Molnar , Yue Hu , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 20/20] cpufreq: Return zero on success in boost sw setting Message-ID: <20200518101109.4uggngudy4gfmlvo@vireshk-i7> References: <20200306124807.3596F80307C2@mail.baikalelectronics.ru> <20200506174238.15385-1-Sergey.Semin@baikalelectronics.ru> <20200506174238.15385-21-Sergey.Semin@baikalelectronics.ru> <20200516125203.et5gkv6ullkerjyd@mobilestation> <20200518074142.c6kbofpdlxro2pjz@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 18-05-20, 11:53, Rafael J. Wysocki wrote: > That said if you really only want it to return 0 on success, you may as well > add a ret = 0; statement (with a comment explaining why it is needed) after > the last break in the loop. That can be done as well, but will be a bit less efficient as the loop will execute once for each policy, and so the statement will run multiple times. Though it isn't going to add any significant latency in the code. -- viresh