* [PATCH -next] MIPS: Loongson64: Make acpi_registers_setup() static
@ 2020-07-03 3:57 Wei Yongjun
2020-07-09 8:09 ` Thomas Bogendoerfer
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2020-07-03 3:57 UTC (permalink / raw)
To: Hulk Robot, Thomas Bogendoerfer, Jiaxun Yang; +Cc: Wei Yongjun, linux-mips
sparse report build warning as follows:
drivers/platform/mips/rs780e-acpi.c:72:6: warning:
symbol 'acpi_registers_setup' was not declared. Should it be static?
And function acpi_registers_setup() is not used outside of this file,
so marks it static.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/platform/mips/rs780e-acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/mips/rs780e-acpi.c b/drivers/platform/mips/rs780e-acpi.c
index e5a643b78ac9..bb0e8ae0eefd 100644
--- a/drivers/platform/mips/rs780e-acpi.c
+++ b/drivers/platform/mips/rs780e-acpi.c
@@ -69,7 +69,7 @@ static void acpi_hw_clear_status(void)
outl(inl(ACPI_GPE0_BLK), ACPI_GPE0_BLK);
}
-void acpi_registers_setup(void)
+static void acpi_registers_setup(void)
{
u32 value;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] MIPS: Loongson64: Make acpi_registers_setup() static
2020-07-03 3:57 [PATCH -next] MIPS: Loongson64: Make acpi_registers_setup() static Wei Yongjun
@ 2020-07-09 8:09 ` Thomas Bogendoerfer
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Bogendoerfer @ 2020-07-09 8:09 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Hulk Robot, Jiaxun Yang, linux-mips
On Fri, Jul 03, 2020 at 11:57:36AM +0800, Wei Yongjun wrote:
> sparse report build warning as follows:
>
> drivers/platform/mips/rs780e-acpi.c:72:6: warning:
> symbol 'acpi_registers_setup' was not declared. Should it be static?
>
> And function acpi_registers_setup() is not used outside of this file,
> so marks it static.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/platform/mips/rs780e-acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-09 8:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-03 3:57 [PATCH -next] MIPS: Loongson64: Make acpi_registers_setup() static Wei Yongjun
2020-07-09 8:09 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).