Re: [PATCH V2] MIPS: Loongson64: Reserve legacy MMIO space according to bridge type

[Thomas Bogendoerfer <tsbogend@alpha.franken.de>]

On Fri, Jul 17, 2020 at 05:10:35PM +0800, Huacai Chen wrote:
> Define MMIO_LOWER_RESERVED as a constant is incorrect, because different
> PCHs (bridge types) have different legacy MMIO space size. According to
> the datasheets, the legacy MMIO space size of LS7A is 0x20000, and which
> of other PCHs is 0x4000. So it is necessary to reserve legacy MMIO space
> according to the bridge type.
> 
> Currently IO_SPACE_LIMIT is defined as 0xffff which is too small for the
> LS7A bridge, so increase it to 0xfffff for LOONGSON64.
> 
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---
>  arch/mips/include/asm/io.h                     |  2 --
>  arch/mips/include/asm/mach-generic/spaces.h    |  4 ++++
>  arch/mips/include/asm/mach-loongson64/spaces.h |  3 +--
>  arch/mips/loongson64/init.c                    | 18 ++++++++++++++----
>  4 files changed, 19 insertions(+), 8 deletions(-)

thank you for the changes. With the new patchset from Jiaxun I'm wondering
which way you want to go ? Should I apply this patch or should I wait
until the new patchset is finalized ?

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]