From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E4D5C433E2 for ; Mon, 14 Sep 2020 20:27:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C7C5620897 for ; Mon, 14 Sep 2020 20:27:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="oF8La/id" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726062AbgINU1Z (ORCPT ); Mon, 14 Sep 2020 16:27:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726144AbgINUUn (ORCPT ); Mon, 14 Sep 2020 16:20:43 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52FFCC061352 for ; Mon, 14 Sep 2020 13:20:36 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id f18so512974pfa.10 for ; Mon, 14 Sep 2020 13:20:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qEpgx25Jil12k55o2aeOued7nizFpjWJtIRv7RIrrgA=; b=oF8La/idpVXp4VfUhwPPRt9IR/o1RPig2nmeyh8YrhsmHCRvroMtluVJ4o5U4K8AFY VbIWbH4IFHNJ2TFc1OFb1H1xtGH98TXoNvfhyYpAj/BvKsAp8ayWj8ANKhK3ots4YK+n 3o6kijVtSkUUK+lTSVOjqNR35ksbqN8yyS7c8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qEpgx25Jil12k55o2aeOued7nizFpjWJtIRv7RIrrgA=; b=ZI4oSjUqWxtjLUCE18zlPBOfUSOKS1QB1tNoMD15FJG7Y/HvY1xRtvufjTvmyJaVZV 4B21R13k59TaC9b6PQm9Il2MT3eeaXusrIB2xs0qmmr4uU2vrRYBY3RPSJEzPTl6WvcC pky62EO3/BVmNFjza3LOcRFVP/gUKMEZra0WhDXqRUPe1CSu3tUZzkDsQIyCia4vdvxW 40D++vKog/9tI8HYLUHCOxxwgDFWhlZRL4XIZ/SW2Mk67G47cUMx/3yHoCaK9LasBzwJ 4UlIZjvcaqVFm9j/jvn57stihgOHj+QNV1NnBZ2tIxaecetTAFP4TkOQdbtWaf2c6vfu AXDA== X-Gm-Message-State: AOAM533vArs70snJuvKK34hKa4+S3xR1VXON4D4j9E3vBseKH/FbktZC nlFJLl8M1lt6QH0l69Mdt2i+Rg== X-Google-Smtp-Source: ABdhPJwzC+6nA3eNHS7MaPMnpM3EiFR22Z/iXFg5GeiL+THEWa6N+D4e+5+NMXy6erXWVC35l1hZ8Q== X-Received: by 2002:a63:471b:: with SMTP id u27mr12121165pga.139.1600114835739; Mon, 14 Sep 2020 13:20:35 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id u6sm10068865pjy.37.2020.09.14.13.20.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 13:20:34 -0700 (PDT) Date: Mon, 14 Sep 2020 13:20:34 -0700 From: Kees Cook To: Michael Ellerman Cc: linux-kernel@vger.kernel.org, Thadeu Lima de Souza Cascardo , Max Filippov , Christian Brauner , Andy Lutomirski , Will Drewry , linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 13/15] selftests/seccomp: powerpc: Set syscall return during ptrace syscall exit Message-ID: <202009141319.FC017B0DB@keescook> References: <20200912110820.597135-1-keescook@chromium.org> <20200912110820.597135-14-keescook@chromium.org> <87zh5sq59a.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zh5sq59a.fsf@mpe.ellerman.id.au> Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Mon, Sep 14, 2020 at 03:47:13PM +1000, Michael Ellerman wrote: > Kees Cook writes: > > Some archs (like ppc) only support changing the return code during > > syscall exit when ptrace is used. As the syscall number might not > > be available anymore during syscall exit, it needs to be saved > > during syscall enter. Adjust the ptrace tests to do this. > > I'm not that across all the fixture stuff, but if I'm reading it right > you're now calling change_syscall() on both entry and exit for all > arches. Correct. > That should work, but it no longer tests changing the return code on > entry on the arches that support it, which seems like a backward step? That's a good point. I wouldn't be in a position to notice a regression for the other architectures. I will refactor this one... -- Kees Cook