Re: [PATCH 1/2] MIPS: cpu-probe: move fpu probing/handling into its own file

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2487 bytes --]

Hi Thomas,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linux/master]
[also build test WARNING on linus/master v5.9-rc8 next-20201008]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Thomas-Bogendoerfer/MIPS-cpu-probe-move-fpu-probing-handling-into-its-own-file/20201009-002949
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git bcf876870b95592b52519ed4aafcf9d95999bc9c
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/9bcc7c604b60699121267371426a9c9ee8559b31
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Thomas-Bogendoerfer/MIPS-cpu-probe-move-fpu-probing-handling-into-its-own-file/20201009-002949
        git checkout 9bcc7c604b60699121267371426a9c9ee8559b31
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> arch/mips/kernel/fpu-probe.c:41:5: warning: no previous prototype for '__cpu_has_fpu' [-Wmissing-prototypes]
      41 | int __cpu_has_fpu(void)
         |     ^~~~~~~~~~~~~
>> arch/mips/kernel/fpu-probe.c:273:6: warning: no previous prototype for 'cpu_set_fpu_opts' [-Wmissing-prototypes]
     273 | void cpu_set_fpu_opts(struct cpuinfo_mips *c)
         |      ^~~~~~~~~~~~~~~~
>> arch/mips/kernel/fpu-probe.c:298:6: warning: no previous prototype for 'cpu_set_nofpu_opts' [-Wmissing-prototypes]
     298 | void cpu_set_nofpu_opts(struct cpuinfo_mips *c)
         |      ^~~~~~~~~~~~~~~~~~

vim +/__cpu_has_fpu +41 arch/mips/kernel/fpu-probe.c

    37	
    38	/*
    39	 * Check if the CPU has an external FPU.
    40	 */
  > 41	int __cpu_has_fpu(void)
    42	{
    43		return (cpu_get_fpu_id() & FPIR_IMP_MASK) != FPIR_IMP_NONE;
    44	}
    45	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 67048 bytes --]