Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] MIPS: cpu-probe: move fpu probing/handling into its own file
Date: Mon, 12 Oct 2020 12:29:34 +0200	[thread overview]
Message-ID: <20201012102934.GA7765@alpha.franken.de> (raw)
In-Reply-To: <alpine.LFD.2.21.2010100128110.866917@eddie.linux-mips.org>

On Sat, Oct 10, 2020 at 01:30:38AM +0100, Maciej W. Rozycki wrote:
> On Thu, 8 Oct 2020, Thomas Bogendoerfer wrote:
> 
> > +			/*
> > +			 * MAC2008 toolchain never landed in real world, so we're only
> > +			 * testing whether it can be disabled and don't try to enabled
> > +			 * it.
> > +			 */
> > +			fcsr0 = fcsr & ~(FPU_CSR_ABS2008 | FPU_CSR_NAN2008 | FPU_CSR_MAC2008);
> > +			write_32bit_cp1_register(CP1_STATUS, fcsr0);
> > +			fcsr0 = read_32bit_cp1_register(CP1_STATUS);
> > +
> > +			fcsr1 = fcsr | FPU_CSR_ABS2008 | FPU_CSR_NAN2008;
> > +			write_32bit_cp1_register(CP1_STATUS, fcsr1);
> > +			fcsr1 = read_32bit_cp1_register(CP1_STATUS);
> > +
> > +			write_32bit_cp1_register(CP1_STATUS, fcsr);
> > +
> > +			if (c->isa_level & (MIPS_CPU_ISA_M32R2 | MIPS_CPU_ISA_M64R2)) {
> > +				/*
> > +				 * The bit for MAC2008 might be reused by R6 in future,
> > +				 * so we only test for R2-R5.
> > +				 */
> 
>  Umm, this has formatting issues with lines extending beyond column #80.

I've fixed it while appling.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

  parent reply	other threads:[~2020-10-12 10:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-08 21:33 [PATCH v2 1/2] MIPS: cpu-probe: move fpu probing/handling into its own file Thomas Bogendoerfer
2020-10-08 21:33 ` [PATCH v2 2/2] MIPS: cpu-probe: introduce exclusive R3k CPU probe Thomas Bogendoerfer
2020-10-12 10:30   ` Thomas Bogendoerfer
2020-10-10  0:30 ` [PATCH v2 1/2] MIPS: cpu-probe: move fpu probing/handling into its own file Maciej W. Rozycki
2020-10-10  8:56   ` Sergei Shtylyov
2020-10-10 12:11     ` Maciej W. Rozycki
2020-10-12 11:17       ` Sergei Shtylyov
2020-10-12 10:29   ` Thomas Bogendoerfer [this message]
2020-10-12 10:30 ` Thomas Bogendoerfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201012102934.GA7765@alpha.franken.de \
    --to=tsbogend@alpha.franken.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=macro@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox