From: Anders Roxell <anders.roxell@linaro.org>
To: tsbogend@alpha.franken.de, natechancellor@gmail.com,
ndesaulniers@google.com
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com,
Anders Roxell <anders.roxell@linaro.org>
Subject: [PATCH] mips: lib: uncached: fix uninitialized variable 'sp'
Date: Fri, 27 Nov 2020 09:39:38 +0100 [thread overview]
Message-ID: <20201127083938.2666770-1-anders.roxell@linaro.org> (raw)
When building mips tinyconfig with clang the following warning show up:
/tmp/arch/mips/lib/uncached.c:40:18: note: initialize the variable 'sp' to silence this warning
register long sp __asm__("$sp");
^
= 0
Rework to make an explicit inline move.
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
arch/mips/lib/uncached.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/mips/lib/uncached.c b/arch/mips/lib/uncached.c
index 09d5deea747f..21a4b94a0558 100644
--- a/arch/mips/lib/uncached.c
+++ b/arch/mips/lib/uncached.c
@@ -37,10 +37,11 @@
*/
unsigned long run_uncached(void *func)
{
- register long sp __asm__("$sp");
register long ret __asm__("$2");
long lfunc = (long)func, ufunc;
long usp;
+ long sp;
+ asm ("move %0, $sp" : "=r" (sp));
if (sp >= (long)CKSEG0 && sp < (long)CKSEG2)
usp = CKSEG1ADDR(sp);
--
2.29.2
next reply other threads:[~2020-11-27 8:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 8:39 Anders Roxell [this message]
2020-11-30 20:22 ` [PATCH] mips: lib: uncached: fix uninitialized variable 'sp' Nick Desaulniers
2020-12-01 0:50 ` Anders Roxell
2020-12-06 9:36 ` Maciej W. Rozycki
2020-12-06 14:33 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201127083938.2666770-1-anders.roxell@linaro.org \
--to=anders.roxell@linaro.org \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).