From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Bert Vermeulen <bert@biot.com>
Cc: Oleksij Rempel <linux@rempel-privat.de>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add support for Realtek RTL838x/RTL839x switch SoCs
Date: Sat, 19 Dec 2020 16:26:16 +0100 [thread overview]
Message-ID: <20201219152616.GA5012@alpha.franken.de> (raw)
In-Reply-To: <a4d89688-347b-21af-ef29-a28cd480d2d9@biot.com>
On Fri, Dec 18, 2020 at 12:27:32AM +0100, Bert Vermeulen wrote:
> On 12/15/20 11:11 PM, Oleksij Rempel wrote:
> > Hello Bert,
> >
> > thank you for your work. Here are some comments..
>
> Thanks for reviewing. I will send in a V2 with your comments all handled.
>
> > I assume, after applying all needed changes, there will be no files within
> > arch/mips/include/asm/mach-realtek :)
>
> I wish! Unfortunately I need somewhere to put the early printk init call,
> and the SoC family ID checks -- as they are heavily used in various drivers.
just as a prevention, don't put realtek specific files into mach-realtek,
but only use realtek as directory name. The mach-xxx directories are
special and I have a mission on my todo to move the non-special files
into their own directores...
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2020-12-19 15:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 18:35 [PATCH] Add support for Realtek RTL838x/RTL839x switch SoCs Bert Vermeulen
2020-12-15 22:11 ` Oleksij Rempel
2020-12-17 23:27 ` Bert Vermeulen
2020-12-18 9:57 ` Oleksij Rempel
2020-12-19 15:26 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201219152616.GA5012@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=bert@biot.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux@rempel-privat.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox