Re: [PATCH 2/6] mips: Add N64 machine type

[Lauri Kasanen <cand@gmx.com>]

On Sat, 26 Dec 2020 11:17:42 +0800
Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:

> > +++ b/arch/mips/n64/init.c
> > +void __init prom_init(void)
> > +{
> > +	int argc, i;
> > +	const char **argv;
> > +
> > +	argc = fw_arg0;
> > +	argv = (const char **)fw_arg1;
> > +
> > +	for (i = 1; i < argc; i++) {
> > +		strlcat(arcs_cmdline, argv[i], COMMAND_LINE_SIZE);
> > +		if (i < (argc - 1))
> > +			strlcat(arcs_cmdline, " ", COMMAND_LINE_SIZE);
> > +	}
> > +}
>
> Please use: fw_init_cmdline.

Will do.

This was copypaste from vr41xx - that place should also be changed then
(by someone who can test it).

> > +++ b/arch/mips/n64/irq.c
> Actually we have plat_irq_dispatch at irq-mips-cpu.c.
> Any special reason to override it?

No, I just didn't know of it. The nicer #define names can still be used
in drivers.

- Lauri