From: Lauri Kasanen <cand@gmx.com>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: linux-mips@vger.kernel.org, tsbogend@alpha.franken.de
Subject: Re: [PATCH 4/6] input: Add N64 controller driver
Date: Sat, 26 Dec 2020 09:41:36 +0200 [thread overview]
Message-ID: <20201226094136.0559ef9741d95bab38da04f6@gmx.com> (raw)
In-Reply-To: <c1d5fdff-cfee-5252-a9f4-7ea6806a1113@flygoat.com>
On Sat, 26 Dec 2020 11:25:49 +0800
Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
> > +#define PIF_RAM 0x1fc007c0
> > +#define REG_BASE ((u32 *) CKSEG1ADDR(0xa4800000))
>
> 0xa4800000 sounds like a KSEG1 addr, I think phys should be 0x14800000?
> For driver it is common to use ioremap, or at least TO_UNCAC.
TO_UNCAC looks like it wouldn't work for vr4300, the manual says
uncached 64-bit space is 0xffff ffff a000 0000, when
include/asm/mach-generic/spaces.h puts the 64bit space start at
0x9000 0000 0000 0000.
ioremap - it looked like needless overhead. Is this a blocker?
The 0xa uncached prefix being in the address already is harmless, it is
the same on both 32-bit and 64-bit on this cpu. I left it in because it
makes it clear to me what kind of address it is, coming from the N64
side.
- Lauri
next prev parent reply other threads:[~2020-12-26 7:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-25 17:01 [PATCH 4/6] input: Add N64 controller driver Lauri Kasanen
2020-12-26 3:25 ` Jiaxun Yang
2020-12-26 7:41 ` Lauri Kasanen [this message]
2020-12-26 10:33 ` Jiaxun Yang
-- strict thread matches above, loose matches on Subject: below --
2021-01-04 13:48 Lauri Kasanen
2021-01-05 22:15 ` Dmitry Torokhov
2021-01-06 7:26 ` Lauri Kasanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201226094136.0559ef9741d95bab38da04f6@gmx.com \
--to=cand@gmx.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-mips@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox