Re: [PATCH 3/6] fbdev: Add n64rdp driver

[Thomas Bogendoerfer <tsbogend@alpha.franken.de>]

On Fri, Dec 25, 2020 at 07:00:48PM +0200, Lauri Kasanen wrote:
> I'm aware of the drm-fbdev resolution, but CONFIG_DRM adds 100kb, which
> is a complete blocker on a system with 8mb RAM.
> 
> Signed-off-by: Lauri Kasanen <cand@gmx.com>
> ---
>  arch/mips/n64/init.c         |  10 +++
>  drivers/video/fbdev/Kconfig  |   9 ++
>  drivers/video/fbdev/Makefile |   1 +
>  drivers/video/fbdev/n64rdp.c | 190 +++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 210 insertions(+)
>  create mode 100644 drivers/video/fbdev/n64rdp.c
> 
> diff --git a/arch/mips/n64/init.c b/arch/mips/n64/init.c
> index 6fb622d..635e9ef 100644
> --- a/arch/mips/n64/init.c
> +++ b/arch/mips/n64/init.c
> @@ -8,6 +8,7 @@
>  #include <linux/ioport.h>
>  #include <linux/irq.h>
>  #include <linux/memblock.h>
> +#include <linux/platform_device.h>
>  #include <linux/string.h>
> 
>  #include <asm/bootinfo.h>
> @@ -46,6 +47,15 @@ void __init prom_free_prom_memory(void)
>  {
>  }
> 
> +static int __init n64_platform_init(void)
> +{
> +	platform_device_register_simple("n64rdp", -1, NULL, 0);
> +
> +	return 0;
> +}
> +
> +arch_initcall(n64_platform_init);
> +
>  void __init plat_mem_setup(void)
>  {
>  	iomem_resource_init();

IMHO it would be better to add the platform device creatioasn to the
MIPS patch. This way there is no dependeny when applying patches by
different maintainers.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]