From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C995C43381 for ; Mon, 4 Jan 2021 14:49:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 17723207BC for ; Mon, 4 Jan 2021 14:49:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727306AbhADOtZ (ORCPT ); Mon, 4 Jan 2021 09:49:25 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:59125 "EHLO relay11.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726396AbhADOtY (ORCPT ); Mon, 4 Jan 2021 09:49:24 -0500 Received: from localhost (lfbn-lyo-1-13-140.w86-202.abo.wanadoo.fr [86.202.109.140]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 64729100013; Mon, 4 Jan 2021 14:48:42 +0000 (UTC) Date: Mon, 4 Jan 2021 15:48:41 +0100 From: Alexandre Belloni To: Geert Uytterhoeven Cc: Jiaxun Yang , "open list:BROADCOM NVRAM DRIVER" , Alessandro Zummo , Linux Kernel Mailing List , linux-rtc@vger.kernel.org Subject: Re: [PATCH 1/2] rtc: goldfish: Remove GOLDFISH dependency Message-ID: <20210104144841.GC3313@piout.net> References: <20201114130921.651882-1-jiaxun.yang@flygoat.com> <20201114130921.651882-2-jiaxun.yang@flygoat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Hi Geert, On 04/01/2021 14:28:26+0100, Geert Uytterhoeven wrote: > Hi Jiaxun, > > On Sat, Nov 14, 2020 at 2:20 PM Jiaxun Yang wrote: > > Goldfish platform is covered with dust. > > However the goldfish-rtc had been used as virtualized RTC > > in QEMU for RISC-V virt hw and MIPS loongson3-virt hw, thus > > we can drop other parts of goldfish but leave goldfish-rtc here. > > > > Signed-off-by: Jiaxun Yang > > Thanks for your patch! > > > --- a/drivers/rtc/Kconfig > > +++ b/drivers/rtc/Kconfig > > @@ -1935,7 +1935,6 @@ config RTC_DRV_HID_SENSOR_TIME > > config RTC_DRV_GOLDFISH > > tristate "Goldfish Real Time Clock" > > depends on OF && HAS_IOMEM > > - depends on GOLDFISH || COMPILE_TEST > > help > > Say yes to enable RTC driver for the Goldfish based virtual platform. > > I was just looking to see if someone had already sent a patch to add > "depends on GOLDFISH || COMPILE_TEST", before sending one myself, when I > noticed your patch had removed it... > > What about > > depends on CPU_LOONGSON64 || GOLDFISH || RISCV || COMPILE_TEST > > instead? > But this driver also works on ARM, is it really important to restrict to a few architectures ? -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com