From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9627C433E0 for ; Wed, 6 Jan 2021 20:15:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F55123138 for ; Wed, 6 Jan 2021 20:15:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726709AbhAFUPJ (ORCPT ); Wed, 6 Jan 2021 15:15:09 -0500 Received: from mail2.protonmail.ch ([185.70.40.22]:13251 "EHLO mail2.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726712AbhAFUPJ (ORCPT ); Wed, 6 Jan 2021 15:15:09 -0500 X-Greylist: delayed 416 seconds by postgrey-1.27 at vger.kernel.org; Wed, 06 Jan 2021 15:15:08 EST Date: Wed, 06 Jan 2021 20:14:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail; t=1609964066; bh=WJzK6tqy2kudlSwkM4O7gMAIJYEZptuNFADdyTc5dhI=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=HwpAema3qYw7H0Uk8Mw4bpCmFURtP/90veXgW/rvDH+kzWJzez0CW6Q+786ZxxOyo BvvlWdgX2LfkqmpIXLlZGnXwRx+33dZ9lMdwn7WK1gvuIoF5C5bFi4o9bAvZmir+uF iD2zd0xHjq4zInQxaOJtr/3QDoX0OHxq8Aa6Ld5k0lpFfW/m69oDZU7Mbo98dlEDBI cWpGNjxFxlMYHasUKvfqillR87YtA4VQ/tpA2jQpjK9uyOCQWzLTFM9cRNiFp9qZif bl3GGXkbwyvRMoznX092HfTqPbGau3RgaJHCAmtBS2wMQwAHCa3j6/PD1SUpJWSAL6 AIS0dkxUi8RGw== To: Nathan Chancellor From: Alexander Lobakin Cc: Alexander Lobakin , Thomas Bogendoerfer , Kees Cook , Ingo Molnar , Fangrui Song , Jiaxun Yang , Ralf Baechle , Alex Smith , Markos Chandras , linux-mips@vger.kernel.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Reply-To: Alexander Lobakin Subject: Re: [PATCH mips-next 0/4] MIPS: vmlinux.lds.S sections fix & cleanup Message-ID: <20210106201400.32416-1-alobakin@pm.me> In-Reply-To: <20210104121729.46981-1-alobakin@pm.me> References: <20210104121729.46981-1-alobakin@pm.me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org From: Nathan Chancellor Date: Mon, 4 Jan 2021 17:09:36 -0700 > On Mon, Jan 04, 2021 at 12:18:10PM +0000, Alexander Lobakin wrote: >> This series hunts the problems discovered after manual enabling of >> ARCH_WANT_LD_ORPHAN_WARN, notably the missing PAGE_ALIGNED_DATA() >> section affecting VDSO placement (marked for stable). >> >> Compile and runtime tested on MIPS32R2 CPS board with no issues. >> >> Alexander Lobakin (4): >> MIPS: vmlinux.lds.S: add missing PAGE_ALIGNED_DATA() section >> MIPS: vmlinux.lds.S: add ".rel.dyn" to DISCARDS >> MIPS: vmlinux.lds.S: add ".gnu.attributes" to DISCARDS >> MIPS: select ARCH_WANT_LD_ORPHAN_WARN >> >> arch/mips/Kconfig | 1 + >> arch/mips/kernel/vmlinux.lds.S | 5 ++++- >> 2 files changed, 5 insertions(+), 1 deletion(-) >> >> -- >> 2.30.0 >> > > Glad to see ARCH_WANT_LD_ORPHAN_WARN catching on :) > > I took this for a spin with clang with malta_kvm_guest_defconfig and I > only see one section unaccounted for: > > $ make -skj"$(nproc)" ARCH=3Dmips CROSS_COMPILE=3Dmipsel-linux-gnu- LLVM= =3D1 O=3Dout/mips distclean malta_kvm_guest_defconfig all > ... > ld.lld: warning: :(.got) is being placed in '.got' > ld.lld: warning: :(.got) is being placed in '.got' > ld.lld: warning: :(.got) is being placed in '.got' > > Looks like most architectures place it in .got (ia64, nios2, powerpc) > or .text (arm64). Addressed in v2, thanks! > Cheers, > Nathan Al