From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CD43C43381 for ; Thu, 7 Jan 2021 16:30:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 385312339E for ; Thu, 7 Jan 2021 16:30:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728649AbhAGQ3q (ORCPT ); Thu, 7 Jan 2021 11:29:46 -0500 Received: from elvis.franken.de ([193.175.24.41]:34735 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726780AbhAGQ3q (ORCPT ); Thu, 7 Jan 2021 11:29:46 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1kxY9o-0000Mi-02; Thu, 07 Jan 2021 17:29:04 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 4A2ECC080E; Thu, 7 Jan 2021 17:26:58 +0100 (CET) Date: Thu, 7 Jan 2021 17:26:58 +0100 From: Thomas Bogendoerfer To: Nathan Chancellor Cc: Florian Fainelli , John Crispin , Nick Desaulniers , bcm-kernel-feedback-list@broadcom.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] MIPS: Use address-of operator on section symbols Message-ID: <20210107162658.GC11882@alpha.franken.de> References: <20210105201827.51766-1-natechancellor@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210105201827.51766-1-natechancellor@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Tue, Jan 05, 2021 at 01:18:27PM -0700, Nathan Chancellor wrote: > When building xway_defconfig with clang: > > arch/mips/lantiq/prom.c:82:23: error: array comparison always evaluates > to true [-Werror,-Wtautological-compare] > else if (__dtb_start != __dtb_end) > ^ > 1 error generated. > > These are not true arrays, they are linker defined symbols, which are > just addresses. Using the address of operator silences the warning > and does not change the resulting assembly with either clang/ld.lld > or gcc/ld (tested with diff + objdump -Dr). Do the same thing across > the entire MIPS subsystem to ensure there are no more warnings around > this type of comparison. > > Link: https://github.com/ClangBuiltLinux/linux/issues/1232 > Signed-off-by: Nathan Chancellor > --- > arch/mips/bmips/setup.c | 2 +- > arch/mips/lantiq/prom.c | 2 +- > arch/mips/pic32/pic32mzda/init.c | 2 +- > arch/mips/ralink/of.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]