Re: [PATCH 2/6] mips: Add N64 machine type

[Lauri Kasanen <cand@gmx.com>]

On Thu, 7 Jan 2021 18:10:35 +0100
Thomas Bogendoerfer <tsbogend@alpha.franken.de> wrote:

> 32BIT kernel don't compile, because you use TO_UNCAC which only
> exists for 64bit kernels. One solution would be to use CKSEG1 to
> convert from physical to an uncached address. But I'd prefer if
> you add resources to your platform device and do ioremap in device
> drivers. This way there is also no need to export the interrupt
> defines outside.

:( Jiaxun told me to use TO_UNCAC because CKSEG1 was unclear to him...

I will change back to CKSEG1. ioremap seems much needless overhead.

> > +#define RCP_IRQ			MIPS_CPU_IRQ(2)
> > +#define CART_IRQ		MIPS_CPU_IRQ(3)
> > +#define PRENMI_IRQ		MIPS_CPU_IRQ(4)
> > +#define RDBR_IRQ		MIPS_CPU_IRQ(5)
> > +#define RDBW_IRQ		MIPS_CPU_IRQ(6)
> > +#define TIMER_IRQ		MIPS_CPU_IRQ(7)
>
> and this IMHO also unsed, so no need to define it.

The sound driver uses the RCP IRQ; the machine-specific names are
defined because they're much more clear.

- Lauri