From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Kevin Hao <haokexin@gmail.com>
Cc: Yasha Cherikovsky <yasha.che3@gmail.com>, linux-mips@vger.kernel.org
Subject: Re: [PATCH v2] Revert "MIPS: Octeon: Remove special handling of CONFIG_MIPS_ELF_APPENDED_DTB=y"
Date: Tue, 19 Jan 2021 23:06:56 +0100 [thread overview]
Message-ID: <20210119220656.GA16804@alpha.franken.de> (raw)
In-Reply-To: <20210119111531.37375-1-haokexin@gmail.com>
On Tue, Jan 19, 2021 at 07:15:31PM +0800, Kevin Hao wrote:
> This reverts commit d9df9fb901d25b941ab2cfb5b570d91fb2abf7a3.
>
> For the OCTEON boards, it need to patch the built-in DTB before using
> it. Previously it judges if it is a built-in DTB by checking
> fw_passed_dtb. But after commit 37e5c69ffd41 ("MIPS: head.S: Init
> fw_passed_dtb to builtin DTB", the fw_passed_dtb is initialized even
> when using built-in DTB. This causes the OCTEON boards boot broken due
> to an unpatched built-in DTB is used. Revert the commit d9df9fb901d2 to
> restore the codes before the fw_passed_dtb is used and then fix this
> issue.
>
> Fixed: 37e5c69ffd41 ("MIPS: head.S: Init fw_passed_dtb to builtin DTB")
> Cc: stable@vger.kernel.org
> Suggested-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Signed-off-by: Kevin Hao <haokexin@gmail.com>
> ---
> arch/mips/cavium-octeon/setup.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2021-01-20 7:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 11:15 [PATCH v2] Revert "MIPS: Octeon: Remove special handling of CONFIG_MIPS_ELF_APPENDED_DTB=y" Kevin Hao
2021-01-19 22:06 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119220656.GA16804@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=haokexin@gmail.com \
--cc=linux-mips@vger.kernel.org \
--cc=yasha.che3@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).