linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] MIPS: process: Fix no previous prototype warning
@ 2021-02-07  8:52 Jinyang He
  2021-02-09 12:37 ` Thomas Bogendoerfer
  0 siblings, 1 reply; 2+ messages in thread
From: Jinyang He @ 2021-02-07  8:52 UTC (permalink / raw)
  To: Thomas Bogendoerfer; +Cc: linux-mips, linux-kernel

unwind_stack_by_address and unwind_stack need <asm/stacktrace.h>.
arch_align_stack needs <asm/exec.h>

link: https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org/thread/ZPL2RRA6RZKRQZI5IGOVLFXN2GVZBN3L/
Fixes: ("MIPS: process: Remove unnecessary headers inclusion")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Jinyang He <hejinyang@loongson.cn>
---
 arch/mips/kernel/process.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/mips/kernel/process.c b/arch/mips/kernel/process.c
index 0c5bc06..2e591df 100644
--- a/arch/mips/kernel/process.c
+++ b/arch/mips/kernel/process.c
@@ -26,6 +26,7 @@
 #include <asm/asm.h>
 #include <asm/dsemul.h>
 #include <asm/dsp.h>
+#include <asm/exec.h>
 #include <asm/fpu.h>
 #include <asm/inst.h>
 #include <asm/irq.h>
@@ -36,6 +37,7 @@
 #include <asm/mipsregs.h>
 #include <asm/processor.h>
 #include <asm/reg.h>
+#include <asm/stacktrace.h>
 
 #ifdef CONFIG_HOTPLUG_CPU
 void arch_cpu_idle_dead(void)
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] MIPS: process: Fix no previous prototype warning
  2021-02-07  8:52 [PATCH] MIPS: process: Fix no previous prototype warning Jinyang He
@ 2021-02-09 12:37 ` Thomas Bogendoerfer
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Bogendoerfer @ 2021-02-09 12:37 UTC (permalink / raw)
  To: Jinyang He; +Cc: linux-mips, linux-kernel

On Sun, Feb 07, 2021 at 04:52:36PM +0800, Jinyang He wrote:
> unwind_stack_by_address and unwind_stack need <asm/stacktrace.h>.
> arch_align_stack needs <asm/exec.h>
> 
> link: https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org/thread/ZPL2RRA6RZKRQZI5IGOVLFXN2GVZBN3L/
> Fixes: ("MIPS: process: Remove unnecessary headers inclusion")

this Fixes is broken, it's missing a git hash. But there is no reason
for a fixes tag, because it "only" removed a warning, but doesn't fix
a bug. So I've removed it while applying the patch.

> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Jinyang He <hejinyang@loongson.cn>
> ---
>  arch/mips/kernel/process.c | 2 ++
>  1 file changed, 2 insertions(+)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-02-09 12:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-07  8:52 [PATCH] MIPS: process: Fix no previous prototype warning Jinyang He
2021-02-09 12:37 ` Thomas Bogendoerfer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).