Re: [PATCH] locking/arch: Move qrwlock.h include after qspinlock.h

Thomas Bogendoerfer
2021-02-10T16:21:07Z

On Wed, Feb 10, 2021 at 09:45:56AM -0500, Waiman Long wrote:
> The queued rwlock code has a dependency on the current spinlock
> implementation (likely to be qspinlock), but not vice versa. Including
> qrwlock.h before qspinlock.h can be problematic when expanding qrwlock
> functionality.
>
> If both qspinlock.h and qrwlock.h are to be included, the qrwlock.h
> include should always be after qspinlock.h. Update the current set of
> asm/spinlock.h files to enforce that.
>
> Signed-off-by: Waiman Long <longman@redhat.com>
> ---
> arch/arm64/include/asm/spinlock.h | 2 +-
> arch/mips/include/asm/spinlock.h | 2 +-
> arch/xtensa/include/asm/spinlock.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)

which tree should this go through ? I can take it via mips-next,
if everybody agrees.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]