From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: Qing Zhang <zhangqing@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] MIPS: Loongson64: Move loongson_system_configuration to loongson.h
Date: Sat, 6 Mar 2021 10:53:08 +0100 [thread overview]
Message-ID: <20210306095308.GA5751@alpha.franken.de> (raw)
In-Reply-To: <d1072504-514b-4be0-85ba-69a6d885de58@www.fastmail.com>
On Sat, Mar 06, 2021 at 05:00:15PM +0800, Jiaxun Yang wrote:
>
>
> On Sat, Mar 6, 2021, at 4:03 PM, Thomas Bogendoerfer wrote:
> > On Thu, Mar 04, 2021 at 07:00:57PM +0800, Qing Zhang wrote:
> > > The purpose of separating loongson_system_configuration from boot_param.h
> > > is to keep the other structure consistent with the firmware.
> > >
> > > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> > > Signed-off-by: Qing Zhang <zhangqing@loongson.cn>
> > > ---
> > > .../include/asm/mach-loongson64/boot_param.h | 18 ------------------
> > > .../include/asm/mach-loongson64/loongson.h | 18 ++++++++++++++++++
> >
> > as you are already touching mach-loongson64 files...
> >
> > Is there a chance you clean up that up even further ? My goal is to
> > have only files in mach-<platform> files, which have an mach-generic
> > counterpart. Everything else should go to its own directory. So in
> > case of loongson something
> >
> > like
> >
> > arch/mips/include/asm/loongson for common stuff
> > arch/mips/include/asm/loongson/32
> > arch/mips/include/asm/loongson/64
>
> Hi Thomas
>
> I'm object to this idea as loongson32/2ef/64 have nothing in common.
at least they share the name loongson, so having
arch/mips/include/asm/loongson
sounds like a good move.
And seeing
diff -u mach-loongson2ef/ mach-loongson64/loongson.h | diffstat
loongson.h | 137 +++++++++++++------------------------------------------------
1 file changed, 30 insertions(+), 107 deletions(-)
wc mach-loongson2ef/loongson.h
318 963 11278 mach-loongson2ef/loongson.h
so there is something to shared. To me it looks like 2ef could be merged
into 64, but that's nothing I'm wanting.
Just to understand you, you want
arch/mips/include/asm/loongson/2ef
arch/mips/include/asm/loongson/32
arch/mips/include/asm/loongson/64
?
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2021-03-06 10:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 11:00 [PATCH 0/2] some cleanup code Qing Zhang
2021-03-04 11:00 ` [PATCH 1/2] MIPS: Loongson64: Remove unused sysconf members Qing Zhang
2021-03-05 2:32 ` Jiaxun Yang
2021-03-06 3:18 ` zhangqing
2021-03-12 10:28 ` Thomas Bogendoerfer
2021-03-04 11:00 ` [PATCH 2/2] MIPS: Loongson64: Move loongson_system_configuration to loongson.h Qing Zhang
2021-03-05 2:32 ` Jiaxun Yang
2021-03-05 10:01 ` Philippe Mathieu-Daudé
2021-03-06 3:12 ` zhangqing
2021-03-06 8:03 ` Thomas Bogendoerfer
2021-03-06 8:57 ` zhangqing
2021-03-09 10:42 ` Thomas Bogendoerfer
2021-03-06 9:00 ` Jiaxun Yang
2021-03-06 9:53 ` Thomas Bogendoerfer [this message]
2021-03-06 10:55 ` Jiaxun Yang
2021-03-08 9:49 ` Thomas Bogendoerfer
2021-03-09 14:48 ` Jiaxun Yang
2021-03-12 10:28 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210306095308.GA5751@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=chenhuacai@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
--cc=zhangqing@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).