From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: linux-mips@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH] MIPS: vmlinux.lds.S: align raw appended dtb to 8 bytes
Date: Mon, 8 Mar 2021 18:47:06 +0100 [thread overview]
Message-ID: <20210308174706.GB13680@alpha.franken.de> (raw)
In-Reply-To: <878s6xbvxm.fsf@miraculix.mork.no>
On Mon, Mar 08, 2021 at 02:45:57PM +0100, Bjørn Mork wrote:
> Thomas Bogendoerfer <tsbogend@alpha.franken.de> writes:
>
> > I see
> >
> > diff --git a/arch/mips/kernel/vmlinux.lds.S b/arch/mips/kernel/vmlinux.lds.S
> > index c1c345be04ff..4b4e39b7c79b 100644
> > --- a/arch/mips/kernel/vmlinux.lds.S
> > +++ b/arch/mips/kernel/vmlinux.lds.S
> > @@ -145,6 +145,7 @@ SECTIONS
> > }
> >
> > #ifdef CONFIG_MIPS_ELF_APPENDED_DTB
> > + STRUCT_ALIGN();
> > .appended_dtb : AT(ADDR(.appended_dtb) - LOAD_OFFSET) {
> > *(.appended_dtb)
> > KEEP(*(.appended_dtb))
> > @@ -172,6 +173,7 @@ SECTIONS
> > #endif
> >
> > #ifdef CONFIG_MIPS_RAW_APPENDED_DTB
> > + STRUCT_ALIGN();
> > __appended_dtb = .;
> > /* leave space for appended DTB */
> > . += 0x100000;
> >
> > in that patch, and IMHO this does align the appended_dtb. What do I miss ?
>
> I'll not pretend I know anything about this subject, so feel free to
> adjust as necessary.
>
> The problem with that patch is that it doesn't pad the image to the
> aligment. So you can't do
>
> cat my.dtb >> arch/mips/boot/vmlinux.bin
>
> anymore. This used to work before commit 79edff12060f.
ok, took a little while to fully understand the problem. I've applied
your patch to mips-fixes with a Fixes: tag added.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2021-03-08 17:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-07 18:23 [PATCH] MIPS: vmlinux.lds.S: align raw appended dtb to 8 bytes Bjørn Mork
2021-03-08 10:55 ` Thomas Bogendoerfer
2021-03-08 11:10 ` Bjørn Mork
2021-03-08 12:53 ` Thomas Bogendoerfer
2021-03-08 13:45 ` Bjørn Mork
2021-03-08 17:47 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210308174706.GB13680@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=bjorn@mork.no \
--cc=frowand.list@gmail.com \
--cc=linux-mips@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox