From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CD25C433E6 for ; Fri, 12 Mar 2021 15:04:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 27E1064FC3 for ; Fri, 12 Mar 2021 15:04:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230256AbhCLPDb (ORCPT ); Fri, 12 Mar 2021 10:03:31 -0500 Received: from elvis.franken.de ([193.175.24.41]:53069 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232131AbhCLPCt (ORCPT ); Fri, 12 Mar 2021 10:02:49 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lKjJN-0002Tu-01; Fri, 12 Mar 2021 16:02:45 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 4C6A6C2118; Fri, 12 Mar 2021 16:00:28 +0100 (CET) Date: Fri, 12 Mar 2021 16:00:28 +0100 From: Thomas Bogendoerfer To: Paul Cercueil Cc: Rob Herring , od@zcrc.me, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: [PATCH 2/2] MIPS: ingenic: gcw0: SPI panel does not require active-high CS Message-ID: <20210312150028.GB3743@alpha.franken.de> References: <20210307192830.208245-1-paul@crapouillou.net> <20210307192830.208245-2-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210307192830.208245-2-paul@crapouillou.net> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Sun, Mar 07, 2021 at 07:28:30PM +0000, Paul Cercueil wrote: > The NT39016 panel is a fun beast, even though the documentation states > that the CS line is active-low, it will work just fine if the CS line is > configured as active-high, but it won't work if the CS line is forced > low or forced high. > > Since it did actually work with the spi-cs-high property, this is not a > bugfix, but we should nonetheless remove that property to match the > documentation. > > Signed-off-by: Paul Cercueil > --- > arch/mips/boot/dts/ingenic/gcw0.dts | 1 - > 1 file changed, 1 deletion(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]