From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F5FAC433E4 for ; Thu, 25 Mar 2021 10:02:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 37D1A61A2A for ; Thu, 25 Mar 2021 10:02:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229519AbhCYKBd (ORCPT ); Thu, 25 Mar 2021 06:01:33 -0400 Received: from elvis.franken.de ([193.175.24.41]:58849 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbhCYKBM (ORCPT ); Thu, 25 Mar 2021 06:01:12 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lPMnd-00074f-00; Thu, 25 Mar 2021 11:01:09 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 10399C1C6A; Thu, 25 Mar 2021 10:55:30 +0100 (CET) Date: Thu, 25 Mar 2021 10:55:29 +0100 From: Thomas Bogendoerfer To: Ilya Lipnitskiy Cc: Matthias Brugger , John Crispin , Chuanhong Guo , Jiaxun Yang , linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: ralink: mt7621: add memory detection support Message-ID: <20210325095529.GA5775@alpha.franken.de> References: <20210317055902.506773-1-ilya.lipnitskiy@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210317055902.506773-1-ilya.lipnitskiy@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Tue, Mar 16, 2021 at 10:59:02PM -0700, Ilya Lipnitskiy wrote: > From: Chuanhong Guo > > mt7621 has the following memory map: > 0x0-0x1c000000: lower 448m memory > 0x1c000000-0x2000000: peripheral registers > 0x20000000-0x2400000: higher 64m memory > > detect_memory_region in arch/mips/kernel/setup.c only adds the first > memory region and isn't suitable for 512m memory detection because > it may accidentally read the memory area for peripheral registers. > > This commit adds memory detection capability for mt7621: > 1. Add the highmem area when 512m is detected. > 2. Guard memcmp from accessing peripheral registers: > This only happens when a user decided to change kernel load address > to 256m or higher address. Since this is a quite unusual case, we > just skip 512m testing and return 256m as memory size. > > [...] I get WARNING: modpost: vmlinux.o(.text+0x132c): Section mismatch in reference from the function prom_soc_init() to the function .init.text:mt7621_memory_detect() The function prom_soc_init() references the function __init mt7621_memory_detect(). This is often because prom_soc_init lacks a __init annotation or the annotation of mt7621_memory_detect is wrong. Can you please fix this ? Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]