From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4F37C433E3 for ; Thu, 25 Mar 2021 10:02:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BAB8A61A30 for ; Thu, 25 Mar 2021 10:02:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230007AbhCYKBc (ORCPT ); Thu, 25 Mar 2021 06:01:32 -0400 Received: from elvis.franken.de ([193.175.24.41]:58851 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229519AbhCYKBM (ORCPT ); Thu, 25 Mar 2021 06:01:12 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lPMnd-00074f-03; Thu, 25 Mar 2021 11:01:09 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 44236C1C81; Thu, 25 Mar 2021 11:00:09 +0100 (CET) Date: Thu, 25 Mar 2021 11:00:09 +0100 From: Thomas Bogendoerfer To: Huang Pei Cc: ambrosehua@gmail.com, Bibo Mao , linux-mips@vger.kernel.org, linux-arch@vger.kernel.org, Jiaxun Yang , Paul Burton , Li Xuefeng , Yang Tiezhu , Gao Juxin , Huacai Chen , Jinyang He Subject: Re: [PATCH] MIPS: loongson64: fix bug when PAGE_SIZE > 16KB Message-ID: <20210325100009.GD5775@alpha.franken.de> References: <20210324032451.27569-1-huangpei@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210324032451.27569-1-huangpei@loongson.cn> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Wed, Mar 24, 2021 at 11:24:51AM +0800, Huang Pei wrote: > When page size larger than 16KB, arguments "vaddr + size(16KB)" in > "ioremap_page_range(vaddr, vaddr + size,...)" called by > "add_legacy_isa_io" is not page-aligned. > > As loongson64 needs at least page size 16KB to get rid of cache alias, > and "vaddr" is 64KB-aligned, and 64KB is largest page size supported, > rounding "size" up to PAGE_SIZE is enough for all page size supported. > > Fixes: 6d0068ad15e4 ("MIPS: Loongson64: Process ISA Node in DeviceTree") > Signed-off-by: Huang Pei > --- > arch/mips/loongson64/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]