From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1069C433C1 for ; Tue, 30 Mar 2021 23:32:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A12C5619CD for ; Tue, 30 Mar 2021 23:32:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233077AbhC3Xbt (ORCPT ); Tue, 30 Mar 2021 19:31:49 -0400 Received: from alln-iport-1.cisco.com ([173.37.142.88]:52070 "EHLO alln-iport-1.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233067AbhC3Xbn (ORCPT ); Tue, 30 Mar 2021 19:31:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2587; q=dns/txt; s=iport; t=1617147103; x=1618356703; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=20ZZL5t0OMdFzBeC8QVdex+kSd6hhKRqsatjmyKFFgA=; b=KYAr2p1ZaYfY8SRXPNZUMg4wXdfmlNfSYB2BNH0LeteApujM0+MT71mT +x82slourELNj0BE0kvkiYTJWHa+2tWzHmQF7+jiCMDCstqB5nG63hUcb 6OjJq1W3dpuA6E8HIDpXRZhW5UwE8EoruBSMcJ88JVakTJVkix2kmjJiw A=; X-IPAS-Result: =?us-ascii?q?A0AUAABmtGNgmJxdJa1aGwEBAQEBAQEBBQEBARIBAQEDA?= =?us-ascii?q?wEBAUCBPgQBAQELAYN2ATkxlhEDkAgWikUUgWgLAQEBDQEBNAQBAYRQAoF6A?= =?us-ascii?q?iU2Bw4CAwEBAQMCAwEBAQEBBQEBAQIBBgQUAQEBAQEBAQGGQ4ZFAQU6PxALE?= =?us-ascii?q?gYVGTwNDgYTgnCDCKsVdYE0iQuBRBQOgRcBjUkmHIFJQoQuPoN5gQaDDIIJI?= =?us-ascii?q?gSBZVsGgRBagSpYFAItkH2CQIpMmw6BFIMRgSObNjEQgziKb5YbuBICBAYFA?= =?us-ascii?q?haBWwongVszGggbFYMkUBkNjjiOTyEDLzgCBgoBAQMJjnkBAQ?= IronPort-HdrOrdr: A9a23:0OR3jKkQkEUngZc1jpNFK2fPV1rpDfN3imdD5ilNYBxZY6Wkvu ql9c516TbfjjENVHY83f2BIrCHW3PA9ZhziLNhWIuKdg/gpWeuMcVe/ZLvqgeQeRHW2+ZB2c 5bGZRWJ8b3CTFB4PrSwA79KNo4xcnCzabAv5a7815IbSVHL55t9B14DAHzKDwUeCBjCYAiHJ SRouprzgDARV0tYs62BmYIUoH4zrWhqLvcbRELHBIh4gWV5AnJ1JfBDxOa0h0COgkg/Z4e9w H+/zDR1+GKr+y8jiTRzXbU6I5b3OH808JZCNaX4/JlTQnEu0KPeJlrXaGEsXQTpuyigWxa6e XkklMHI9l57W/XcyWOhSbVnyPk0Doo9hbZuDmlvUc= X-IronPort-Anti-Spam-Filtered: true X-IronPort-AV: E=Sophos;i="5.81,291,1610409600"; d="scan'208";a="668463184" Received: from rcdn-core-5.cisco.com ([173.37.93.156]) by alln-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 30 Mar 2021 23:31:40 +0000 Received: from zorba ([10.24.9.230]) by rcdn-core-5.cisco.com (8.15.2/8.15.2) with ESMTPS id 12UNVcQt021992 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 30 Mar 2021 23:31:39 GMT Date: Tue, 30 Mar 2021 16:31:37 -0700 From: Daniel Walker To: Rob Herring Cc: Christophe Leroy , Will Deacon , Daniel Gimpelevich , Andrew Morton , X86 ML , "open list:MIPS" , linuxppc-dev , xe-linux-external@cisco.com, Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline Message-ID: <20210330233137.GB2469518@zorba> References: <20210309000247.2989531-4-danielwa@cisco.com> <5f865584-09c9-d21f-ffb7-23cf07cf058e@csgroup.eu> <20210309212944.GR109100@zorba> <20fd7d44-8c39-48bc-25c3-990be9d9d911@csgroup.eu> <20210325195956.GM109100@zorba> <20210330173254.GS109100@zorba> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Auto-Response-Suppress: DR, OOF, AutoReply X-Outbound-SMTP-Client: 10.24.9.230, [10.24.9.230] X-Outbound-Node: rcdn-core-5.cisco.com Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Tue, Mar 30, 2021 at 03:13:04PM -0500, Rob Herring wrote: > On Tue, Mar 30, 2021 at 12:33 PM Daniel Walker wrote: > > > > On Thu, Mar 25, 2021 at 05:29:44PM -0600, Rob Herring wrote: > > > On Thu, Mar 25, 2021 at 2:00 PM Daniel Walker wrote: > > > > > > > > On Thu, Mar 25, 2021 at 01:03:55PM +0100, Christophe Leroy wrote: > > > > > > > > > > Ok, so you agree we don't need to provide two CMDLINE, one to be appended and one to be prepended. > > > > > > > > > > Let's only provide once CMDLINE as of today, and ask the user to select > > > > > whether he wants it appended or prepended or replacee. Then no need to > > > > > change all existing config to rename CONFIG_CMDLINE into either of the new > > > > > ones. > > > > > > > > > > That's the main difference between my series and Daniel's series. So I'll > > > > > finish taking Will's comment into account and we'll send out a v3 soon. > > > > > > > > It doesn't solve the needs of Cisco, I've stated many times your changes have > > > > little value. Please stop submitting them. > > > > > > Can you please outline what those needs are which aren't met? > > > > append AND prepend at the same time on all architectures. Christophe doesn't > > understand the need, and hence tries to minimize the feature set which is > > incompatible with Cisco needs and all the other out of tree users. > > Okay, but that's never been a feature in upstream. For upstream, we > refactor first and add features 2nd. In this case, the difference is > largely the kconfig and it would be better to not change the options > twice, but that's not a blocker for taking the refactoring. You won't > find a maintainer that's going to take adding a feature over cleanups > and unification. It kind of is a feature in upstream, it's a matter of opinion. Some platform used append and some use prepend, and it's likely because the maintainers needed one or the other for development. I'm not sure why you think I can't add the features in one go. It would be horrid to take Christophe's changes, then have to do basically all the same work a second time which is what Christophe's changes would force me to do. Say for example I implement this change only on one architecture. In that case the maintainer would be accepting a feature enhancement , but there would be no stopping it. I shouldn't have to go two strokes on one architecture, but each change I'm making is essentially a single architecture. They can go in all together or one at a time. Daniel