linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@kernel.org>
To: Zhou Yanjie <zhouyanjie@wanyeetech.com>
Cc: paul@crapouillou.net, stable@vger.kernel.org,
	linux-mips@vger.kernel.org, linux-i2c@vger.kernel.org,
	linux-kernel@vger.kernel.org, dongsheng.qiu@ingenic.com,
	aric.pzqi@ingenic.com, sernia.zhou@foxmail.com
Subject: Re: [PATCH] I2C: JZ4780: Fix bug for Ingenic X1000.
Date: Wed, 31 Mar 2021 09:18:35 +0200	[thread overview]
Message-ID: <20210331071835.GB1025@ninjato> (raw)
In-Reply-To: <644d19d8-9444-4dde-a891-c9dfd523389e@wanyeetech.com>

[-- Attachment #1: Type: text/plain, Size: 635 bytes --]

Hi, 

> > Any write operation? I wonder then why nobody noticed before?
> 
> 
> The standard I2C communication should look like this:
> 
> Read:
> 
> device_addr + w, reg_addr, device_addr + r, data;
> 
> Write:
> 
> device_addr + w, reg_addr, data;
> 
> 
> But without this patch, it looks like this:
> 
> Read:
> 
> device_addr + w, reg_addr, device_addr + r, data;
> 
> Write:
> 
> device_addr + w, reg_addr, device_addr + w, data;
> 
> This is clearly not correct.

Thanks for the additional information! I understand now. I added a bit
of this to the commit message of v2 to explain the situation.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-03-31  7:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-18 16:25 Fix bug for Ingenic X1000 周琰杰 (Zhou Yanjie)
2021-03-18 16:25 ` [PATCH] I2C: JZ4780: " 周琰杰 (Zhou Yanjie)
2021-03-18 17:01   ` Greg KH
2021-03-18 17:06   ` Wolfram Sang
2021-03-19  6:58     ` Zhou Yanjie
2021-03-31  7:18       ` Wolfram Sang [this message]
2021-04-02 15:30         ` Zhou Yanjie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210331071835.GB1025@ninjato \
    --to=wsa@kernel.org \
    --cc=aric.pzqi@ingenic.com \
    --cc=dongsheng.qiu@ingenic.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=paul@crapouillou.net \
    --cc=sernia.zhou@foxmail.com \
    --cc=stable@vger.kernel.org \
    --cc=zhouyanjie@wanyeetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).