From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA84AC43611 for ; Tue, 6 Apr 2021 13:18:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3629613D2 for ; Tue, 6 Apr 2021 13:18:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243661AbhDFNSx (ORCPT ); Tue, 6 Apr 2021 09:18:53 -0400 Received: from elvis.franken.de ([193.175.24.41]:59078 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242526AbhDFNSr (ORCPT ); Tue, 6 Apr 2021 09:18:47 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lTlbK-0006qP-03; Tue, 06 Apr 2021 15:18:38 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 0A7CBC24D9; Tue, 6 Apr 2021 15:06:30 +0200 (CEST) Date: Tue, 6 Apr 2021 15:06:29 +0200 From: Thomas Bogendoerfer To: Huacai Chen Cc: linux-mips@vger.kernel.org, Jiaxun Yang , Huacai Chen , stable@vger.kernel.org Subject: Re: [PATCH] MIPS: Fix a longstanding error in div64.h Message-ID: <20210406130629.GE9505@alpha.franken.de> References: <20210406112404.2671507-1-chenhuacai@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210406112404.2671507-1-chenhuacai@loongson.cn> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Tue, Apr 06, 2021 at 07:24:03PM +0800, Huacai Chen wrote: > Only 32bit kernel need __div64_32(), but commit c21004cd5b4cb7d479514d4 > ("MIPS: Rewrite to work with gcc 4.4.0.") makes it depend > on 64bit kernel by mistake. This patch fix this longstanding error. > > Fixes: c21004cd5b4cb7d479514d4 ("MIPS: Rewrite to work with gcc 4.4.0.") > Cc: stable@vger.kernel.org > Signed-off-by: Huacai Chen > --- > arch/mips/include/asm/div64.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/include/asm/div64.h b/arch/mips/include/asm/div64.h > index dc5ea5736440..d199fe36eb46 100644 > --- a/arch/mips/include/asm/div64.h > +++ b/arch/mips/include/asm/div64.h > @@ -11,7 +11,7 @@ > > #include > > -#if BITS_PER_LONG == 64 > +#if BITS_PER_LONG == 32 are you sure this will make a difference ? asm-generic/div64.h checks for __div64_32, which is not defined before including it here. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]