From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86D2EC433B4 for ; Mon, 26 Apr 2021 13:01:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C1D061263 for ; Mon, 26 Apr 2021 13:01:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233619AbhDZNCT (ORCPT ); Mon, 26 Apr 2021 09:02:19 -0400 Received: from elvis.franken.de ([193.175.24.41]:43655 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233593AbhDZNCT (ORCPT ); Mon, 26 Apr 2021 09:02:19 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lb0rm-0001U1-00; Mon, 26 Apr 2021 15:01:34 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id DF10CC0BBF; Mon, 26 Apr 2021 15:00:05 +0200 (CEST) Date: Mon, 26 Apr 2021 15:00:05 +0200 From: Thomas Bogendoerfer To: zhouchuangao Cc: Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: BCM63XX: Use BUG_ON instead of condition followed by BUG. Message-ID: <20210426130005.GA9176@alpha.franken.de> References: <1619279992-81335-1-git-send-email-zhouchuangao@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1619279992-81335-1-git-send-email-zhouchuangao@vivo.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Sat, Apr 24, 2021 at 08:59:50AM -0700, zhouchuangao wrote: > BUG_ON uses unlikely in if(), it can be optimized at compile time. > > Usually, the condition in if() is not satisfied. In my opinion, > this can improve the efficiency of the multi-stage pipeline. > > Signed-off-by: zhouchuangao > --- > arch/mips/bcm63xx/gpio.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]