Re: [PATCH v2 1/6] rtc: ls2x: Add support for the Loongson-2K/LS7A RTC

kernel test robot
2021-05-05T21:57:32Z

[-- Attachment #1: Type: text/plain, Size: 3059 bytes --]

Hi WANG,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on next-20210505]
[cannot apply to abelloni/rtc-next robh/for-next v5.12]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/WANG-Xuerui/rtc-ls2x-Add-support-for-the-Loongson-2K-LS7A-RTC/20210506-013703
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git d665ea6ea86c785760ee4bad4543dab3267ad074
config: parisc-allyesconfig (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/a4a12242f17c2ad92025b724458a31eb088e1893
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review WANG-Xuerui/rtc-ls2x-Add-support-for-the-Loongson-2K-LS7A-RTC/20210506-013703
git checkout a4a12242f17c2ad92025b724458a31eb088e1893
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=parisc

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

drivers/rtc/rtc-ls2x.c: In function 'ls2x_rtc_probe':
drivers/rtc/rtc-ls2x.c:202:9: error: implicit declaration of function 'rtc_register_device'; did you mean 'devm_rtc_register_device'? [-Werror=implicit-function-declaration]
202 | return rtc_register_device(rtc);
| ^~~~~~~~~~~~~~~~~~~
| devm_rtc_register_device
drivers/rtc/rtc-ls2x.c: At top level:
drivers/rtc/rtc-ls2x.c:215:21: error: implicit declaration of function 'of_match_ptr' [-Werror=implicit-function-declaration]
215 | .of_match_table = of_match_ptr(ls2x_rtc_of_match),
| ^~~~~~~~~~~~
>> drivers/rtc/rtc-ls2x.c:215:21: warning: initialization of 'const struct of_device_id *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
drivers/rtc/rtc-ls2x.c:215:21: note: (near initialization for 'ls2x_rtc_driver.driver.of_match_table')
drivers/rtc/rtc-ls2x.c:215:21: error: initializer element is not constant
drivers/rtc/rtc-ls2x.c:215:21: note: (near initialization for 'ls2x_rtc_driver.driver.of_match_table')
cc1: some warnings being treated as errors

vim +215 drivers/rtc/rtc-ls2x.c

210
211 static struct platform_driver ls2x_rtc_driver = {
212 .probe = ls2x_rtc_probe,
213 .driver = {
214 .name = "ls2x-rtc",
> 215 .of_match_table = of_match_ptr(ls2x_rtc_of_match),
216 },
217 };
218

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 68536 bytes --]