From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD050C48BE5 for ; Mon, 21 Jun 2021 09:54:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B633361151 for ; Mon, 21 Jun 2021 09:54:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229707AbhFUJ4Z (ORCPT ); Mon, 21 Jun 2021 05:56:25 -0400 Received: from elvis.franken.de ([193.175.24.41]:40941 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229651AbhFUJ4Z (ORCPT ); Mon, 21 Jun 2021 05:56:25 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lvGd7-000490-02; Mon, 21 Jun 2021 11:54:09 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id ECFC2C071C; Mon, 21 Jun 2021 11:46:31 +0200 (CEST) Date: Mon, 21 Jun 2021 11:46:31 +0200 From: Thomas Bogendoerfer To: Huang Pei Cc: ambrosehua@gmail.com, Bibo Mao , linux-mips@vger.kernel.org, Jiaxun Yang , Paul Burton , Li Xuefeng , Yang Tiezhu , Gao Juxin , Huacai Chen , Jinyang He Subject: Re: [PATCH] MIPS: add PMD table accounting into MIPS'pmd_alloc_one Message-ID: <20210621094631.GC4425@alpha.franken.de> References: <20210611070946.302901-1-huangpei@loongson.cn> <20210611070946.302901-2-huangpei@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210611070946.302901-2-huangpei@loongson.cn> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Fri, Jun 11, 2021 at 03:09:46PM +0800, Huang Pei wrote: > This fixes Page Table accounting bug. > > MIPS is the ONLY arch just defining __HAVE_ARCH_PMD_ALLOC_ONE alone. > Since commit b2b29d6d011944 (mm: account PMD tables like PTE tables), > "pmd_free" in asm-generic with PMD table accounting and "pmd_alloc_one" > in MIPS without PMD table accounting causes PageTable accounting number > negative, which read by global_zone_page_state(), always returns 0. > > Signed-off-by: Huang Pei > --- > arch/mips/include/asm/pgalloc.h | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]