From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF241C433FE for ; Tue, 28 Sep 2021 11:59:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9AF51611C7 for ; Tue, 28 Sep 2021 11:59:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240499AbhI1MBZ (ORCPT ); Tue, 28 Sep 2021 08:01:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:41898 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240503AbhI1MBY (ORCPT ); Tue, 28 Sep 2021 08:01:24 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D7A0561159; Tue, 28 Sep 2021 11:59:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632830385; bh=zMYBfWvCNkFzxdrnbweDkDMHXlvN68VeGQ+0I0PA/d8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EN/nPH2gh0WaxZze2kAw8Ok6z3UgQlhFMRx/0O3fExpPs36mEyK0xTTZ30IpXIlBB IkNlNXSD3sxzE5YSY/Soa7VGIQjCLZhRGWTxcE6j7jGV/jcAZ1ZGzSePySFQaNSF5N dAOkXU9MaDd6iFR0MKXNm/VNH3+vZc7ji20tThZhDSWtat3EL+yCeONizzhyPjU4y6 OZNfF2MmephniDoiA0monFa1t+B7T+0P+v5sZLHqIQM58lTvFB3JS87J4nhqnAsm0F jirrD/U6QDySZiLSxBE9RG9Y3W5qc2GJLWhIDnjRW4vUBuha2O8TDvDfHfU/hqB7z3 pswWVPVnQT0dA== Date: Tue, 28 Sep 2021 12:58:56 +0100 From: Mark Brown To: Arnd Bergmann Cc: Bjorn Andersson , Arnd Bergmann , Liam Girdwood , Charles Keepax , Simon Trimmer , Michael Ellerman , Russell King , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Paul Walmsley , Palmer Dabbelt , Albert Ou , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Geert Uytterhoeven , Linus Walleij , Andrew Morton , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH 1/2] firmware: include drivers/firmware/Kconfig unconditionally Message-ID: <20210928115856.GK4199@sirena.org.uk> References: <20210928075216.4193128-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mPOSj6iWmtyhwOMz" Content-Disposition: inline In-Reply-To: <20210928075216.4193128-1-arnd@kernel.org> X-Cookie: 98% lean. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org --mPOSj6iWmtyhwOMz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 28, 2021 at 09:50:26AM +0200, Arnd Bergmann wrote: > Compile-testing drivers that require access to a firmware layer > fails when that firmware symbol is unavailable. This happened > twice this week: ... > We should probably do the same thing for other subsystems as well, > but fix this one first as this is a dependency for other patches > getting merged. Reviwed-by: Mark Brown Regardless of what we do with the Cirrus DSP this just seems like a good idea - surprises due to this not being generally available keep coming up, IIRC with the i.MX firmware in the past for example. > Not sure how we'd want to merge this patch, if two other things > need it. I'd prefer to merge it along with the QCOM_SCM change > through the soc tree, but that leaves the cirrus firmware broken > unless we also merge it the same way (rather than through ASoC > as it is now). We could also merge a tag into both places. > Alternatively, we can try to find a different home for the Cirrus > firmware to decouple the two problems. I'd argue that it's actually > misplaced here, as drivers/firmware is meant for kernel code that > interfaces with system firmware, not for device drivers to load > their own firmware blobs from user space. Trying to enforce distinctions here feels like it's liable to lead to trouble at some point... --mPOSj6iWmtyhwOMz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFTA38ACgkQJNaLcl1U h9DErAf7BZ8NtQuQy3+q/sK46z5J4UG49n7Ro2RwX1QsUE9ptW/j3QNct+oR2NtG 686Ywi+SLiwvjt9AOMEEwLrMr8VpbfKHtzNF3IFoqlZcIltP8SikGt7hl1drc7Ht 5s1rVT2od8Z49zvKru0SLEmIczlvfThmmEe7hH0klv/7eiYsIse//b/7UbCk03lc BSU0mVLjlyBSIN6k6yU5V/JUnUwwNaWlTMficv4UITM2Ba6zjFS2WE2NlUhLcCv/ yHwgZhRm3quHTTRoJDelHsIqz65f4GxgXsMm4Olo/IZswnUh9Uk/LNMKRcHvlPg2 lP63ixob10ht4mAPh8V0shZi3aeH4g== =nQ30 -----END PGP SIGNATURE----- --mPOSj6iWmtyhwOMz--