From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DA52C433F5 for ; Wed, 29 Sep 2021 10:17:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B1726135E for ; Wed, 29 Sep 2021 10:17:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245430AbhI2KTZ (ORCPT ); Wed, 29 Sep 2021 06:19:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:49948 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245508AbhI2KTK (ORCPT ); Wed, 29 Sep 2021 06:19:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 596CC613CD; Wed, 29 Sep 2021 10:17:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632910650; bh=ApwjsuHkRLKIvYsUtPvCU+3a2n55yhVlsEyPpAqiq0Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c7UIdY1ptOrLLATvIT6DQbSfUmSx4SW/6eQVuBkuabAAD6uJYv4KiaePlAqUnYzIO GWvJvq0km3JiPj6oi8WIpC7VAhVnopNtYfFQ5TfCQmqWH/jYFXW5/5nc9UXGqjZfMb s4b9oUKpC2NR2W8UPrHHup6LTDl/yvXmNXhJnb4D4YqHdXiDvgoKL1VAUTAE/OzaT/ h7v+R1Nu8NrQgzctHkX8920rEm0HTH/b5a/VWhWRUhVBHJLYHe88ZnR+UOy/kHxHQm KJlpI5M79mfgpL7cLLj6EGaYGvFx8zdBTlGWVrlYSSCCzBuvmaOxsoj8MrcBrikKei DEg8ELCDAzEng== Date: Wed, 29 Sep 2021 11:17:21 +0100 From: Will Deacon To: Arnd Bergmann Cc: Bjorn Andersson , Arnd Bergmann , Mark Brown , Liam Girdwood , Charles Keepax , Simon Trimmer , Michael Ellerman , Russell King , Catalin Marinas , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Paul Walmsley , Palmer Dabbelt , Albert Ou , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Geert Uytterhoeven , Linus Walleij , Andrew Morton , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH 1/2] firmware: include drivers/firmware/Kconfig unconditionally Message-ID: <20210929101721.GC21057@willie-the-truck> References: <20210928075216.4193128-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210928075216.4193128-1-arnd@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Tue, Sep 28, 2021 at 09:50:26AM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Compile-testing drivers that require access to a firmware layer > fails when that firmware symbol is unavailable. This happened > twice this week: > > - My proposed to change to rework the QCOM_SCM firmware symbol > broke on ppc64 and others. > > - The cs_dsp firmware patch added device specific firmware loader > into drivers/firmware, which broke on the same set of > architectures. > > We should probably do the same thing for other subsystems as well, > but fix this one first as this is a dependency for other patches > getting merged. > > Cc: Mark Brown > Cc: Liam Girdwood > Cc: Charles Keepax > Cc: Simon Trimmer > Cc: Arnd Bergmann > Cc: Michael Ellerman > Signed-off-by: Arnd Bergmann > --- > Not sure how we'd want to merge this patch, if two other things > need it. I'd prefer to merge it along with the QCOM_SCM change > through the soc tree, but that leaves the cirrus firmware broken > unless we also merge it the same way (rather than through ASoC > as it is now). > > Alternatively, we can try to find a different home for the Cirrus > firmware to decouple the two problems. I'd argue that it's actually > misplaced here, as drivers/firmware is meant for kernel code that > interfaces with system firmware, not for device drivers to load > their own firmware blobs from user space. > --- > arch/arm/Kconfig | 2 -- > arch/arm64/Kconfig | 2 -- > arch/ia64/Kconfig | 2 -- > arch/mips/Kconfig | 2 -- > arch/parisc/Kconfig | 2 -- > arch/riscv/Kconfig | 2 -- > arch/x86/Kconfig | 2 -- > drivers/Kconfig | 2 ++ > 8 files changed, 2 insertions(+), 14 deletions(-) For arm64: Acked-by: Will Deacon Will