From: Oleksij Rempel <o.rempel@pengutronix.de>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Rob Herring <robh@kernel.org>,
Paul Burton <paulburton@kernel.org>,
linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
linux-mips@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: Re: [PATCH v1] MIPS: Malta: fix alignment of the devicetree buffer
Date: Mon, 11 Oct 2021 09:15:53 +0200 [thread overview]
Message-ID: <20211011071553.GA24717@pengutronix.de> (raw)
In-Reply-To: <alpine.DEB.2.21.2110101148550.12214@angie.orcam.me.uk>
On Sun, Oct 10, 2021 at 11:58:24AM +0200, Maciej W. Rozycki wrote:
> On Thu, 2 Sep 2021, Marc Kleine-Budde wrote:
>
> > > > Starting with following patch MIPS Malta is not able to boot:
> > > > | commit 79edff12060fe7772af08607eff50c0e2486c5ba
> > > > | Author: Rob Herring <robh@kernel.org>
> > > > | scripts/dtc: Update to upstream version v1.6.0-51-g183df9e9c2b9
> >
> > If the above patch broke malts, IMHO the fixes tag should be:
> >
> > Fixes: 79edff12060f ("scripts/dtc: Update to upstream version v1.6.0-51-g183df9e9c2b9")
>
> It's not clear either from this patch description or from the commit
> referred what the actual *purpose* of the alignment check is and therefore
> I think it's hard to say which of the two commits needs to be indicated as
> the offender. Without further data I tend to agree it's 79edff12060f that
> ought to be referred, being the immediate cause of the regression, as
> things obviously worked before, for 5+ years.
This patch was already taken. Do I need to do any thing?
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2021-10-11 7:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 7:19 [PATCH v1] MIPS: Malta: fix alignment of the devicetree buffer Oleksij Rempel
2021-09-02 9:03 ` Thomas Bogendoerfer
2021-09-02 10:14 ` Marc Kleine-Budde
2021-10-10 9:58 ` Maciej W. Rozycki
2021-10-11 7:15 ` Oleksij Rempel [this message]
2021-10-11 8:09 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211011071553.GA24717@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=mkl@pengutronix.de \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
--cc=robh@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).