* [PATCH AUTOSEL 5.10 11/11] firmware: include drivers/firmware/Kconfig unconditionally [not found] <20211013005532.700190-1-sashal@kernel.org> @ 2021-10-13 0:55 ` Sasha Levin 2021-10-13 5:58 ` Greg KH 0 siblings, 1 reply; 5+ messages in thread From: Sasha Levin @ 2021-10-13 0:55 UTC (permalink / raw) To: linux-kernel, stable Cc: Arnd Bergmann, Bjorn Andersson, Charles Keepax, Will Deacon, Mark Brown, Liam Girdwood, Simon Trimmer, Michael Ellerman, Sasha Levin, linux, catalin.marinas, tsbogend, James.Bottomley, deller, paul.walmsley, palmer, aou, tglx, mingo, bp, x86, linus.walleij, geert+renesas, rmk+kernel, akpm, anshuman.khandual, mark.rutland, ardb, u.kleine-koenig, rppt, lukas.bulwahn, wangkefeng.wang, slyfox, axboe, ben.widawsky, dan.j.williams, gregkh, linux-arm-kernel, linux-ia64, linux-mips, linux-parisc, linux-riscv From: Arnd Bergmann <arnd@arndb.de> [ Upstream commit 951cd3a0866d29cb9c01ebc1d9c17590e598226e ] Compile-testing drivers that require access to a firmware layer fails when that firmware symbol is unavailable. This happened twice this week: - My proposed to change to rework the QCOM_SCM firmware symbol broke on ppc64 and others. - The cs_dsp firmware patch added device specific firmware loader into drivers/firmware, which broke on the same set of architectures. We should probably do the same thing for other subsystems as well, but fix this one first as this is a dependency for other patches getting merged. Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com> Acked-by: Will Deacon <will@kernel.org> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: Mark Brown <broonie@kernel.org> Cc: Liam Girdwood <lgirdwood@gmail.com> Cc: Charles Keepax <ckeepax@opensource.cirrus.com> Cc: Simon Trimmer <simont@opensource.cirrus.com> Cc: Michael Ellerman <mpe@ellerman.id.au> Reviewed-by: Mark Brown <broonie@kernel.org> Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Sasha Levin <sashal@kernel.org> --- arch/arm/Kconfig | 2 -- arch/arm64/Kconfig | 2 -- arch/ia64/Kconfig | 2 -- arch/mips/Kconfig | 2 -- arch/parisc/Kconfig | 2 -- arch/riscv/Kconfig | 2 -- arch/x86/Kconfig | 2 -- drivers/Kconfig | 2 ++ 8 files changed, 2 insertions(+), 14 deletions(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 002e0cf025f5..d4c6b95b24d7 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -2043,8 +2043,6 @@ config ARCH_HIBERNATION_POSSIBLE endmenu -source "drivers/firmware/Kconfig" - if CRYPTO source "arch/arm/crypto/Kconfig" endif diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 5e5cf3af6351..f4809760a806 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -1933,8 +1933,6 @@ source "drivers/cpufreq/Kconfig" endmenu -source "drivers/firmware/Kconfig" - source "drivers/acpi/Kconfig" source "arch/arm64/kvm/Kconfig" diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig index 39b25a5a591b..e8014d2e36c0 100644 --- a/arch/ia64/Kconfig +++ b/arch/ia64/Kconfig @@ -426,8 +426,6 @@ config CRASH_DUMP help Generate crash dump after being started by kexec. -source "drivers/firmware/Kconfig" - endmenu menu "Power management and ACPI options" diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index 1a63f592034e..3bd3a01a2a2b 100644 --- a/arch/mips/Kconfig +++ b/arch/mips/Kconfig @@ -3328,8 +3328,6 @@ source "drivers/cpuidle/Kconfig" endmenu -source "drivers/firmware/Kconfig" - source "arch/mips/kvm/Kconfig" source "arch/mips/vdso/Kconfig" diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig index 14f3252f2da0..ad13477fb40c 100644 --- a/arch/parisc/Kconfig +++ b/arch/parisc/Kconfig @@ -378,6 +378,4 @@ config KEXEC_FILE endmenu -source "drivers/firmware/Kconfig" - source "drivers/parisc/Kconfig" diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index f7abd118d23d..fcb8e5da148e 100644 --- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -428,5 +428,3 @@ menu "Power management options" source "kernel/power/Kconfig" endmenu - -source "drivers/firmware/Kconfig" diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index f3c8a8110f60..499f3cc1e62f 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -2899,8 +2899,6 @@ config HAVE_ATOMIC_IOMAP def_bool y depends on X86_32 -source "drivers/firmware/Kconfig" - source "arch/x86/kvm/Kconfig" source "arch/x86/Kconfig.assembler" diff --git a/drivers/Kconfig b/drivers/Kconfig index dcecc9f6e33f..493ac7ffd8d0 100644 --- a/drivers/Kconfig +++ b/drivers/Kconfig @@ -16,6 +16,8 @@ source "drivers/bus/Kconfig" source "drivers/connector/Kconfig" +source "drivers/firmware/Kconfig" + source "drivers/gnss/Kconfig" source "drivers/mtd/Kconfig" -- 2.33.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH AUTOSEL 5.10 11/11] firmware: include drivers/firmware/Kconfig unconditionally 2021-10-13 0:55 ` [PATCH AUTOSEL 5.10 11/11] firmware: include drivers/firmware/Kconfig unconditionally Sasha Levin @ 2021-10-13 5:58 ` Greg KH 2021-10-13 8:38 ` Arnd Bergmann 0 siblings, 1 reply; 5+ messages in thread From: Greg KH @ 2021-10-13 5:58 UTC (permalink / raw) To: Sasha Levin Cc: linux-kernel, stable, Arnd Bergmann, Bjorn Andersson, Charles Keepax, Will Deacon, Mark Brown, Liam Girdwood, Simon Trimmer, Michael Ellerman, linux, catalin.marinas, tsbogend, James.Bottomley, deller, paul.walmsley, palmer, aou, tglx, mingo, bp, x86, linus.walleij, geert+renesas, rmk+kernel, akpm, anshuman.khandual, mark.rutland, ardb, u.kleine-koenig, rppt, lukas.bulwahn, wangkefeng.wang, slyfox, axboe, ben.widawsky, dan.j.williams, linux-arm-kernel, linux-ia64, linux-mips, linux-parisc, linux-riscv On Tue, Oct 12, 2021 at 08:55:31PM -0400, Sasha Levin wrote: > From: Arnd Bergmann <arnd@arndb.de> > > [ Upstream commit 951cd3a0866d29cb9c01ebc1d9c17590e598226e ] > > Compile-testing drivers that require access to a firmware layer > fails when that firmware symbol is unavailable. This happened > twice this week: > > - My proposed to change to rework the QCOM_SCM firmware symbol > broke on ppc64 and others. > > - The cs_dsp firmware patch added device specific firmware loader > into drivers/firmware, which broke on the same set of > architectures. > > We should probably do the same thing for other subsystems as well, > but fix this one first as this is a dependency for other patches > getting merged. > > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com> > Acked-by: Will Deacon <will@kernel.org> > Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Mark Brown <broonie@kernel.org> > Cc: Liam Girdwood <lgirdwood@gmail.com> > Cc: Charles Keepax <ckeepax@opensource.cirrus.com> > Cc: Simon Trimmer <simont@opensource.cirrus.com> > Cc: Michael Ellerman <mpe@ellerman.id.au> > Reviewed-by: Mark Brown <broonie@kernel.org> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Sasha Levin <sashal@kernel.org> > --- > arch/arm/Kconfig | 2 -- > arch/arm64/Kconfig | 2 -- > arch/ia64/Kconfig | 2 -- > arch/mips/Kconfig | 2 -- > arch/parisc/Kconfig | 2 -- > arch/riscv/Kconfig | 2 -- > arch/x86/Kconfig | 2 -- > drivers/Kconfig | 2 ++ > 8 files changed, 2 insertions(+), 14 deletions(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 002e0cf025f5..d4c6b95b24d7 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -2043,8 +2043,6 @@ config ARCH_HIBERNATION_POSSIBLE > > endmenu > > -source "drivers/firmware/Kconfig" > - > if CRYPTO > source "arch/arm/crypto/Kconfig" > endif > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 5e5cf3af6351..f4809760a806 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -1933,8 +1933,6 @@ source "drivers/cpufreq/Kconfig" > > endmenu > > -source "drivers/firmware/Kconfig" > - > source "drivers/acpi/Kconfig" > > source "arch/arm64/kvm/Kconfig" > diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig > index 39b25a5a591b..e8014d2e36c0 100644 > --- a/arch/ia64/Kconfig > +++ b/arch/ia64/Kconfig > @@ -426,8 +426,6 @@ config CRASH_DUMP > help > Generate crash dump after being started by kexec. > > -source "drivers/firmware/Kconfig" > - > endmenu > > menu "Power management and ACPI options" > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index 1a63f592034e..3bd3a01a2a2b 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -3328,8 +3328,6 @@ source "drivers/cpuidle/Kconfig" > > endmenu > > -source "drivers/firmware/Kconfig" > - > source "arch/mips/kvm/Kconfig" > > source "arch/mips/vdso/Kconfig" > diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig > index 14f3252f2da0..ad13477fb40c 100644 > --- a/arch/parisc/Kconfig > +++ b/arch/parisc/Kconfig > @@ -378,6 +378,4 @@ config KEXEC_FILE > > endmenu > > -source "drivers/firmware/Kconfig" > - > source "drivers/parisc/Kconfig" > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index f7abd118d23d..fcb8e5da148e 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -428,5 +428,3 @@ menu "Power management options" > source "kernel/power/Kconfig" > > endmenu > - > -source "drivers/firmware/Kconfig" > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index f3c8a8110f60..499f3cc1e62f 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -2899,8 +2899,6 @@ config HAVE_ATOMIC_IOMAP > def_bool y > depends on X86_32 > > -source "drivers/firmware/Kconfig" > - > source "arch/x86/kvm/Kconfig" > > source "arch/x86/Kconfig.assembler" > diff --git a/drivers/Kconfig b/drivers/Kconfig > index dcecc9f6e33f..493ac7ffd8d0 100644 > --- a/drivers/Kconfig > +++ b/drivers/Kconfig > @@ -16,6 +16,8 @@ source "drivers/bus/Kconfig" > > source "drivers/connector/Kconfig" > > +source "drivers/firmware/Kconfig" > + > source "drivers/gnss/Kconfig" > > source "drivers/mtd/Kconfig" > -- > 2.33.0 > This isn't for stable kernels, it should be dropped from all of your AUTOSEL queues. thanks, greg k-h ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH AUTOSEL 5.10 11/11] firmware: include drivers/firmware/Kconfig unconditionally 2021-10-13 5:58 ` Greg KH @ 2021-10-13 8:38 ` Arnd Bergmann 2021-10-13 8:45 ` Uwe Kleine-König 0 siblings, 1 reply; 5+ messages in thread From: Arnd Bergmann @ 2021-10-13 8:38 UTC (permalink / raw) To: Greg KH Cc: Sasha Levin, Linux Kernel Mailing List, # 3.4.x, Arnd Bergmann, Bjorn Andersson, Charles Keepax, Will Deacon, Mark Brown, Liam Girdwood, Simon Trimmer, Michael Ellerman, Russell King - ARM Linux, Catalin Marinas, Thomas Bogendoerfer, James Bottomley, Helge Deller, Paul Walmsley, Palmer Dabbelt, Albert Ou, Thomas Gleixner, Ingo Molnar, Borislav Petkov, the arch/x86 maintainers, Linus Walleij, Geert Uytterhoeven, Russell King, Andrew Morton, Anshuman Khandual, Mark Rutland, Ard Biesheuvel, Uwe Kleine-König, Mike Rapoport, Lukas Bulwahn, Kefeng Wang, Sergei Trofimovich, Jens Axboe, ben.widawsky, Dan Williams, Linux ARM, linux-ia64, open list:BROADCOM NVRAM DRIVER, Parisc List, linux-riscv On Wed, Oct 13, 2021 at 7:58 AM Greg KH <gregkh@linuxfoundation.org> wrote: > On Tue, Oct 12, 2021 at 08:55:31PM -0400, Sasha Levin wrote: > > This isn't for stable kernels, it should be dropped from all of your > AUTOSEL queues. Agreed. The second patch that depends on this does fix a (randconfig) build issue in stable kernels as well, but that patch is currently broken, and the two patches combined do feel a little too invasive for addressing such a minor issue in the stable kernels. If anyone runs into the QCOM_SCM link failures on stable kernels, I can come up with a more localized fix. Arnd ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH AUTOSEL 5.10 11/11] firmware: include drivers/firmware/Kconfig unconditionally 2021-10-13 8:38 ` Arnd Bergmann @ 2021-10-13 8:45 ` Uwe Kleine-König 2021-10-13 8:50 ` Arnd Bergmann 0 siblings, 1 reply; 5+ messages in thread From: Uwe Kleine-König @ 2021-10-13 8:45 UTC (permalink / raw) To: Arnd Bergmann Cc: Greg KH, Sasha Levin, Linux Kernel Mailing List, # 3.4.x, Bjorn Andersson, Charles Keepax, Will Deacon, Mark Brown, Liam Girdwood, Simon Trimmer, Michael Ellerman, Russell King - ARM Linux, Catalin Marinas, Thomas Bogendoerfer, James Bottomley, Helge Deller, Paul Walmsley, Palmer Dabbelt, Albert Ou, Thomas Gleixner, Ingo Molnar, Borislav Petkov, the arch/x86 maintainers, Linus Walleij, Geert Uytterhoeven, Russell King, Andrew Morton, Anshuman Khandual, Mark Rutland, Ard Biesheuvel, Mike Rapoport, Lukas Bulwahn, Kefeng Wang, Sergei Trofimovich, Jens Axboe, ben.widawsky, Dan Williams, Linux ARM, linux-ia64, open list:BROADCOM NVRAM DRIVER, Parisc List, linux-riscv [-- Attachment #1: Type: text/plain, Size: 858 bytes --] On Wed, Oct 13, 2021 at 10:38:01AM +0200, Arnd Bergmann wrote: > On Wed, Oct 13, 2021 at 7:58 AM Greg KH <gregkh@linuxfoundation.org> wrote: > > On Tue, Oct 12, 2021 at 08:55:31PM -0400, Sasha Levin wrote: > > > > This isn't for stable kernels, it should be dropped from all of your > > AUTOSEL queues. > > Agreed. The second patch that depends on this does fix a (randconfig) > build issue in stable kernels as well, but that patch is currently broken, Fixing randconfig issues isn't important for stable, is it? The target audience for 5.10.74 are people running a kernel between 5.10 and 5.10.73, and those don't suffer from this type of build problem, right? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH AUTOSEL 5.10 11/11] firmware: include drivers/firmware/Kconfig unconditionally 2021-10-13 8:45 ` Uwe Kleine-König @ 2021-10-13 8:50 ` Arnd Bergmann 0 siblings, 0 replies; 5+ messages in thread From: Arnd Bergmann @ 2021-10-13 8:50 UTC (permalink / raw) To: Uwe Kleine-König Cc: Arnd Bergmann, Greg KH, Sasha Levin, Linux Kernel Mailing List, # 3.4.x, Bjorn Andersson, Charles Keepax, Will Deacon, Mark Brown, Liam Girdwood, Simon Trimmer, Michael Ellerman, Russell King - ARM Linux, Catalin Marinas, Thomas Bogendoerfer, James Bottomley, Helge Deller, Paul Walmsley, Palmer Dabbelt, Albert Ou, Thomas Gleixner, Ingo Molnar, Borislav Petkov, the arch/x86 maintainers, Linus Walleij, Geert Uytterhoeven, Russell King, Andrew Morton, Anshuman Khandual, Mark Rutland, Ard Biesheuvel, Mike Rapoport, Lukas Bulwahn, Kefeng Wang, Sergei Trofimovich, Jens Axboe, ben.widawsky, Dan Williams, Linux ARM, linux-ia64, open list:BROADCOM NVRAM DRIVER, Parisc List, linux-riscv On Wed, Oct 13, 2021 at 10:45 AM Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > On Wed, Oct 13, 2021 at 10:38:01AM +0200, Arnd Bergmann wrote: > > On Wed, Oct 13, 2021 at 7:58 AM Greg KH <gregkh@linuxfoundation.org> wrote: > > > On Tue, Oct 12, 2021 at 08:55:31PM -0400, Sasha Levin wrote: > > > > > > This isn't for stable kernels, it should be dropped from all of your > > > AUTOSEL queues. > > > > Agreed. The second patch that depends on this does fix a (randconfig) > > build issue in stable kernels as well, but that patch is currently broken, > > Fixing randconfig issues isn't important for stable, is it? The target > audience for 5.10.74 are people running a kernel between 5.10 and > 5.10.73, and those don't suffer from this type of build problem, right? In general, I think randconfig build testing is useful for validating stable kernels, to help avoid regressions, but there are a number of known randconfig problems that you hit much more frequently than this one, which only breaks once every few hundred kernel builds. Arnd ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-13 8:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20211013005532.700190-1-sashal@kernel.org>
2021-10-13 0:55 ` [PATCH AUTOSEL 5.10 11/11] firmware: include drivers/firmware/Kconfig unconditionally Sasha Levin
2021-10-13 5:58 ` Greg KH
2021-10-13 8:38 ` Arnd Bergmann
2021-10-13 8:45 ` Uwe Kleine-König
2021-10-13 8:50 ` Arnd Bergmann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox