linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Geert Uytterhoeven <geert@linux-m68k.org>,
	Miguel Ojeda <ojeda@kernel.org>
Cc: lkp@intel.com, kbuild-all@lists.01.org,
	Robin van der Gracht <robin@protonic.nl>,
	Rob Herring <robh+dt@kernel.org>,
	Paul Burton <paulburton@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Pavel Machek <pavel@ucw.cz>, Marek Behun <marek.behun@nic.cz>,
	devicetree@vger.kernel.org, linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org
Subject: Re: [PATCH v7 18/21] auxdisplay: ht16k33: Add support for segment displays
Date: Fri, 15 Oct 2021 11:47:38 +0300	[thread overview]
Message-ID: <202110150246.UAF2lniv-lkp@intel.com> (raw)
In-Reply-To: <20211012183327.649865-19-geert@linux-m68k.org>

Hi Geert,

url:    https://github.com/0day-ci/linux/commits/Geert-Uytterhoeven/auxdisplay-ht16k33-Add-character-display-support/20211013-025705
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: i386-randconfig-m031-20211012 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
include/uapi/linux/map_to_14segment.h:87 map_to_seg14() error: buffer overflow 'map->table' 128 <= 255
include/uapi/linux/map_to_14segment.h:87 map_to_seg14() error: buffer overflow 'map->table' 128 <= 255
include/uapi/linux/map_to_14segment.h:87 map_to_seg14() error: buffer overflow 'map->table' 128 <= 255

vim +87 include/uapi/linux/map_to_14segment.h

d26423994040a7 Geert Uytterhoeven 2021-10-12  85  static __inline__ int map_to_seg14(struct seg14_conversion_map *map, int c)
d26423994040a7 Geert Uytterhoeven 2021-10-12  86  {
d26423994040a7 Geert Uytterhoeven 2021-10-12 @87  	return c >= 0 && c < sizeof(map->table) ? __be16_to_cpu(map->table[c])
                                                                         ^^^^^^^^^^^^^^^^^^^^^^
This needs to be c < ARRAY_SIZE(map->table) instead of sizeof().

d26423994040a7 Geert Uytterhoeven 2021-10-12  88  						: -EINVAL;
d26423994040a7 Geert Uytterhoeven 2021-10-12  89  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org


  reply	other threads:[~2021-10-15  8:48 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-12 18:33 [PATCH v7 00/21] auxdisplay: ht16k33: Add character display support Geert Uytterhoeven
2021-10-12 18:33 ` [PATCH v7 01/21] uapi: Add <linux/map_to_14segment.h> Geert Uytterhoeven
2021-10-12 18:33 ` [PATCH v7 02/21] dt-bindings: auxdisplay: ht16k33: Document Adafruit segment displays Geert Uytterhoeven
2021-10-12 18:33 ` [PATCH v7 03/21] auxdisplay: img-ascii-lcd: Fix lock-up when displaying empty string Geert Uytterhoeven
2021-10-12 18:33 ` [PATCH v7 04/21] auxdisplay: img-ascii-lcd: Add helper variable dev Geert Uytterhoeven
2021-10-12 18:33 ` [PATCH v7 05/21] auxdisplay: img-ascii-lcd: Convert device attribute to sysfs_emit() Geert Uytterhoeven
2021-10-12 18:33 ` [PATCH v7 06/21] auxdisplay: Extract character line display core support Geert Uytterhoeven
2021-10-12 18:33 ` [PATCH v7 07/21] auxdisplay: linedisp: Use kmemdup_nul() helper Geert Uytterhoeven
2021-10-12 18:33 ` [PATCH v7 08/21] auxdisplay: linedisp: Add support for changing scroll rate Geert Uytterhoeven
2021-10-12 18:33 ` [PATCH v7 09/21] auxdisplay: ht16k33: Connect backlight to fbdev Geert Uytterhoeven
2021-10-12 18:33 ` [PATCH v7 10/21] auxdisplay: ht16k33: Fix frame buffer device blanking Geert Uytterhoeven
2021-10-12 18:33 ` [PATCH v7 11/21] auxdisplay: ht16k33: Use HT16K33_FB_SIZE in ht16k33_initialize() Geert Uytterhoeven
2021-10-12 18:33 ` [PATCH v7 12/21] auxdisplay: ht16k33: Remove unneeded error check in keypad probe() Geert Uytterhoeven
2021-10-12 18:33 ` [PATCH v7 13/21] auxdisplay: ht16k33: Convert to simple i2c probe function Geert Uytterhoeven
2021-10-12 18:33 ` [PATCH v7 14/21] auxdisplay: ht16k33: Add helper variable dev Geert Uytterhoeven
2021-10-12 18:33 ` [PATCH v7 15/21] auxdisplay: ht16k33: Move delayed work Geert Uytterhoeven
2021-10-12 18:33 ` [PATCH v7 16/21] auxdisplay: ht16k33: Extract ht16k33_brightness_set() Geert Uytterhoeven
2021-10-12 18:33 ` [PATCH v7 17/21] auxdisplay: ht16k33: Extract frame buffer probing Geert Uytterhoeven
2021-10-12 18:33 ` [PATCH v7 18/21] auxdisplay: ht16k33: Add support for segment displays Geert Uytterhoeven
2021-10-15  8:47   ` Dan Carpenter [this message]
2021-10-15  8:59     ` Geert Uytterhoeven
2021-10-12 18:33 ` [PATCH v7 19/21] dt-bindings: auxdisplay: ht16k33: Document LED subnode Geert Uytterhoeven
2021-10-12 18:33 ` [PATCH v7 20/21] auxdisplay: ht16k33: Add LED support Geert Uytterhoeven
2021-10-13  7:27   ` Robin van der Gracht
2021-10-12 18:33 ` [PATCH v7 21/21] auxdisplay: ht16k33: Make use of device properties Geert Uytterhoeven
2021-10-13  7:28   ` Robin van der Gracht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202110150246.UAF2lniv-lkp@intel.com \
    --to=dan.carpenter@oracle.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kbuild-all@lists.01.org \
    --cc=kbuild@lists.01.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=marek.behun@nic.cz \
    --cc=ojeda@kernel.org \
    --cc=paulburton@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    --cc=robin@protonic.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).