From: Marc Zyngier <maz@kernel.org>
To: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Serge Semin <fancer.lancer@gmail.com>,
Huacai Chen <chenhuacai@kernel.org>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
f.fainelli@gmail.com, Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH 1/3] MIPS: loongson64: Drop call to irq_cpu_offline()
Date: Thu, 21 Oct 2021 18:04:12 +0100 [thread overview]
Message-ID: <20211021170414.3341522-2-maz@kernel.org> (raw)
In-Reply-To: <20211021170414.3341522-1-maz@kernel.org>
Also loongson64 calls irq_cpu_offline(), none of its interrupt
controllers implement the .irq_cpu_offline callback.
It is thus obvious that this call only serves the dubious purpose
of wasting precious CPU cycles by iterating over all interrupts.
Get rid of the call altogether.
Signed-off-by: Marc Zyngier <maz@kernel.org>
---
arch/mips/loongson64/smp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/mips/loongson64/smp.c b/arch/mips/loongson64/smp.c
index 09ebe84a17fe..660e1de4412a 100644
--- a/arch/mips/loongson64/smp.c
+++ b/arch/mips/loongson64/smp.c
@@ -550,7 +550,6 @@ static int loongson3_cpu_disable(void)
set_cpu_online(cpu, false);
calculate_cpu_foreign_map();
local_irq_save(flags);
- irq_cpu_offline();
clear_c0_status(ST0_IM);
local_irq_restore(flags);
local_flush_tlb_all();
--
2.30.2
next prev parent reply other threads:[~2021-10-21 17:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 17:04 [PATCH 0/3] genirq: Make irq_cpu_{on,off}line() an Octeon-special Marc Zyngier
2021-10-21 17:04 ` Marc Zyngier [this message]
2021-10-24 15:28 ` [PATCH 1/3] MIPS: loongson64: Drop call to irq_cpu_offline() Thomas Bogendoerfer
2021-10-26 2:16 ` Florian Fainelli
2021-10-21 17:04 ` [PATCH 2/3] irqchip/mips-gic: Get rid of the reliance on irq_cpu_online() Marc Zyngier
2021-10-22 13:57 ` Serge Semin
2021-10-26 2:17 ` Florian Fainelli
2021-10-21 17:04 ` [PATCH 3/3] genirq: Hide irq_cpu_{on,off}line() behind a deprecated option Marc Zyngier
2021-10-26 2:41 ` Florian Fainelli
2021-10-22 13:53 ` [PATCH 0/3] genirq: Make irq_cpu_{on,off}line() an Octeon-special Serge Semin
2021-10-22 13:59 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211021170414.3341522-2-maz@kernel.org \
--to=maz@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=fancer.lancer@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).