From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-mips@vger.kernel.org, Jason Self <jason@bluehome.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] MIPS: fix *-pkg builds for loongson2ef platform
Date: Tue, 9 Nov 2021 16:32:27 +0100 [thread overview]
Message-ID: <20211109153227.GA13509@alpha.franken.de> (raw)
In-Reply-To: <20211109150146.529428-1-masahiroy@kernel.org>
On Wed, Nov 10, 2021 at 12:01:45AM +0900, Masahiro Yamada wrote:
> Since commit 805b2e1d427a ("kbuild: include Makefile.compiler only when
> compiler is needed"), package builds for the loongson2f platform fail.
>
> $ make ARCH=mips CROSS_COMPILE=mips64-linux- lemote2f_defconfig bindeb-pkg
> [ snip ]
> sh ./scripts/package/builddeb
> arch/mips/loongson2ef//Platform:36: *** only binutils >= 2.20.2 have needed option -mfix-loongson2f-nop. Stop.
> cp: cannot stat '': No such file or directory
> make[5]: *** [scripts/Makefile.package:87: intdeb-pkg] Error 1
> make[4]: *** [Makefile:1558: intdeb-pkg] Error 2
> make[3]: *** [debian/rules:13: binary-arch] Error 2
> dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
> make[2]: *** [scripts/Makefile.package:83: bindeb-pkg] Error 2
> make[1]: *** [Makefile:1558: bindeb-pkg] Error 2
> make: *** [Makefile:350: __build_one_by_one] Error 2
>
> The reason is because "make image_name" fails.
>
> $ make ARCH=mips CROSS_COMPILE=mips64-linux- image_name
> arch/mips/loongson2ef//Platform:36: *** only binutils >= 2.20.2 have needed option -mfix-loongson2f-nop. Stop.
>
> In general, adding $(error ...) in the parse stage is troublesome,
> and it is pointless to check toolchains even if we are not building
> anything. Do not include Kbuild.platform in such cases.
>
> Fixes: 805b2e1d427a ("kbuild: include Makefile.compiler only when compiler is needed")
> Reported-by: Jason Self <jason@bluehome.net>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> arch/mips/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index e036fc025ccc..ace7f033de07 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -253,7 +253,9 @@ endif
> #
> # Board-dependent options and extra files
> #
> +ifdef need-compiler
> include $(srctree)/arch/mips/Kbuild.platforms
> +endif
>
> ifdef CONFIG_PHYSICAL_START
> load-y = $(CONFIG_PHYSICAL_START)
> --
> 2.30.2
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2021-11-09 15:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 15:01 [PATCH 1/2] MIPS: fix *-pkg builds for loongson2ef platform Masahiro Yamada
2021-11-09 15:01 ` [PATCH 2/2] MIPS: fix duplicated slashes for Platform file path Masahiro Yamada
2021-11-09 15:32 ` Thomas Bogendoerfer
2021-11-09 15:32 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211109153227.GA13509@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=jason@bluehome.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).