From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1006BC433EF for ; Thu, 25 Nov 2021 09:37:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354128AbhKYJkr (ORCPT ); Thu, 25 Nov 2021 04:40:47 -0500 Received: from elvis.franken.de ([193.175.24.41]:40429 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354150AbhKYJiq (ORCPT ); Thu, 25 Nov 2021 04:38:46 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1mqBA6-00032R-00; Thu, 25 Nov 2021 10:35:26 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id B8A25C2F25; Thu, 25 Nov 2021 10:32:56 +0100 (CET) Date: Thu, 25 Nov 2021 10:32:56 +0100 From: Thomas Bogendoerfer To: Paul Cercueil Cc: Arnd Bergmann , Masahiro Yamada , Randy Dunlap , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, list@opendingux.net Subject: Re: [PATCH] MIPS: boot/compressed/: add __ashldi3 to target for ZSTD compression Message-ID: <20211125093256.GA6537@alpha.franken.de> References: <20211119175052.401771-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211119175052.401771-1-paul@crapouillou.net> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Fri, Nov 19, 2021 at 05:50:52PM +0000, Paul Cercueil wrote: > Just like before with __bswapdi2(), for MIPS pre-boot when > CONFIG_KERNEL_ZSTD=y the decompressor function will use __ashldi3(), so > the object file should be added to the target object file. > > Fixes these build errors: > > mipsel-linux-ld: arch/mips/boot/compressed/decompress.o: in function `FSE_buildDTable_internal': > decompress.c:(.text.FSE_buildDTable_internal+0x48): undefined reference to `__ashldi3' > mipsel-linux-ld: arch/mips/boot/compressed/decompress.o: in function `FSE_decompress_wksp_body_default': > decompress.c:(.text.FSE_decompress_wksp_body_default+0xa8): undefined reference to `__ashldi3' > mipsel-linux-ld: arch/mips/boot/compressed/decompress.o: in function `ZSTD_getFrameHeader_advanced': > decompress.c:(.text.ZSTD_getFrameHeader_advanced+0x134): undefined reference to `__ashldi3' > > Signed-off-by: Paul Cercueil > --- > arch/mips/boot/compressed/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/boot/compressed/Makefile b/arch/mips/boot/compressed/Makefile > index 2861a05c2e0c..f27cf31b4140 100644 > --- a/arch/mips/boot/compressed/Makefile > +++ b/arch/mips/boot/compressed/Makefile > @@ -52,7 +52,7 @@ endif > > vmlinuzobjs-$(CONFIG_KERNEL_XZ) += $(obj)/ashldi3.o > > -vmlinuzobjs-$(CONFIG_KERNEL_ZSTD) += $(obj)/bswapdi.o > +vmlinuzobjs-$(CONFIG_KERNEL_ZSTD) += $(obj)/bswapdi.o $(obj)/ashldi3.o > > targets := $(notdir $(vmlinuzobjs-y)) > > -- > 2.33.0 applied to mips-fixes. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]