From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02441C433F5 for ; Wed, 5 Jan 2022 10:05:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234220AbiAEKF2 (ORCPT ); Wed, 5 Jan 2022 05:05:28 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:4338 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229611AbiAEKF2 (ORCPT ); Wed, 5 Jan 2022 05:05:28 -0500 Received: from fraeml741-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4JTQ4z716Bz67lk0; Wed, 5 Jan 2022 18:02:11 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml741-chm.china.huawei.com (10.206.15.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 5 Jan 2022 11:05:25 +0100 Received: from localhost (10.47.83.118) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Wed, 5 Jan 2022 10:05:24 +0000 Date: Wed, 5 Jan 2022 10:05:30 +0000 From: Jonathan Cameron To: Paul Cercueil CC: "Rafael J . Wysocki" , Ulf Hansson , Jonathan Cameron , "Lars-Peter Clausen" , Linus Walleij , "Arnd Bergmann" , Len Brown , Pavel Machek , , , , , , Subject: Re: [PATCH 4/8] PM: runtime: Add DEFINE_RUNTIME_DEV_PM_OPS() macro Message-ID: <20220105100530.0000589f@Huawei.com> In-Reply-To: <20220104214214.198843-5-paul@crapouillou.net> References: <20220104214214.198843-1-paul@crapouillou.net> <20220104214214.198843-5-paul@crapouillou.net> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.83.118] X-ClientProxiedBy: lhreml704-chm.china.huawei.com (10.201.108.53) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Tue, 4 Jan 2022 21:42:10 +0000 Paul Cercueil wrote: > A lot of drivers create a dev_pm_ops struct with the system sleep > suspend/resume callbacks set to pm_runtime_force_suspend() and > pm_runtime_force_resume(). > > These drivers can now use the DEFINE_RUNTIME_DEV_PM_OPS() macro, which > will use pm_runtime_force_{suspend,resume}() as the system sleep > callbacks, while having the same dead code removal characteristic that > is already provided by DEFINE_SIMPLE_DEV_PM_OPS(). > > Signed-off-by: Paul Cercueil I guess this is common enough to bother with a macro. Reviewed-by: Jonathan Cameron > --- > include/linux/pm.h | 3 +++ > include/linux/pm_runtime.h | 14 ++++++++++++++ > 2 files changed, 17 insertions(+) > > diff --git a/include/linux/pm.h b/include/linux/pm.h > index a1ce29566aea..01c4fe495b7a 100644 > --- a/include/linux/pm.h > +++ b/include/linux/pm.h > @@ -411,6 +411,9 @@ const struct dev_pm_ops __maybe_unused name = { \ > * suspend and "early" resume callback pointers, .suspend_late() and > * .resume_early(), to the same routines as .runtime_suspend() and > * .runtime_resume(), respectively (and analogously for hibernation). > + * > + * Deprecated. You most likely don't want this macro. Use > + * DEFINE_RUNTIME_DEV_PM_OPS() instead. > */ > #define UNIVERSAL_DEV_PM_OPS(name, suspend_fn, resume_fn, idle_fn) \ > const struct dev_pm_ops __maybe_unused name = { \ > diff --git a/include/linux/pm_runtime.h b/include/linux/pm_runtime.h > index 016de5776b6d..4af454d29281 100644 > --- a/include/linux/pm_runtime.h > +++ b/include/linux/pm_runtime.h > @@ -22,6 +22,20 @@ > usage_count */ > #define RPM_AUTO 0x08 /* Use autosuspend_delay */ > > +/* > + * Use this for defining a set of PM operations to be used in all situations > + * (system suspend, hibernation or runtime PM). > + * > + * Note that the behaviour differs from the deprecated UNIVERSAL_DEV_PM_OPS() > + * macro, which uses the provided callbacks for both runtime PM and system > + * sleep, while DEFINE_RUNTIME_DEV_PM_OPS() uses pm_runtime_force_suspend() > + * and pm_runtime_force_resume() for its system sleep callbacks. > + */ > +#define DEFINE_RUNTIME_DEV_PM_OPS(name, suspend_fn, resume_fn, idle_fn) \ > + _DEFINE_DEV_PM_OPS(name, pm_runtime_force_suspend, \ > + pm_runtime_force_resume, suspend_fn, \ > + resume_fn, idle_fn) > + > #ifdef CONFIG_PM > extern struct workqueue_struct *pm_wq; >