linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Siarhei Volkau <lis8215@gmail.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-mips@vger.kernel.org, linux-clk@vger.kernel.org,
	Siarhei Volkau <lis8215@gmail.com>
Subject: [PATCH v2 1/1] clk: jz4725b: fix mmc0 clock gating
Date: Fri,  4 Feb 2022 10:21:41 +0300	[thread overview]
Message-ID: <20220204072141.542909-2-lis8215@gmail.com> (raw)
In-Reply-To: <20220204072141.542909-1-lis8215@gmail.com>

The mmc0 clock gate bit was mistakenly assigned to "i2s" clock.
You can find that the same bit is assigned to "mmc0" too.
It leads to mmc0 hang for a long time after any sound activity
also it  prevented PM_SLEEP to work properly.
I guess it was introduced by copy-paste from jz4740 driver
where it is really controls I2S clock gate.

Signed-off-by: Siarhei Volkau <lis8215@gmail.com>
Tested-by: Siarhei Volkau <lis8215@gmail.com>
---
 drivers/clk/ingenic/jz4725b-cgu.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/clk/ingenic/jz4725b-cgu.c b/drivers/clk/ingenic/jz4725b-cgu.c
index 744d136..15d6179 100644
--- a/drivers/clk/ingenic/jz4725b-cgu.c
+++ b/drivers/clk/ingenic/jz4725b-cgu.c
@@ -139,11 +139,10 @@ static const struct ingenic_cgu_clk_info jz4725b_cgu_clocks[] = {
 	},
 
 	[JZ4725B_CLK_I2S] = {
-		"i2s", CGU_CLK_MUX | CGU_CLK_DIV | CGU_CLK_GATE,
+		"i2s", CGU_CLK_MUX | CGU_CLK_DIV,
 		.parents = { JZ4725B_CLK_EXT, JZ4725B_CLK_PLL_HALF, -1, -1 },
 		.mux = { CGU_REG_CPCCR, 31, 1 },
 		.div = { CGU_REG_I2SCDR, 0, 1, 9, -1, -1, -1 },
-		.gate = { CGU_REG_CLKGR, 6 },
 	},
 
 	[JZ4725B_CLK_SPI] = {
-- 
2.35.1


  reply	other threads:[~2022-02-04  7:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-04  5:26 [PATCH 0/1] clk: jz4725b: fix mmc0 clock gating Siarhei Volkau
2022-02-04  5:26 ` [PATCH 1/1] " Siarhei Volkau
2022-02-04  6:23 ` [PATCH 0/1] " Paul Cercueil
2022-02-04  6:53   ` Siarhei Volkau
2022-02-04  7:21   ` [PATCH v2 " Siarhei Volkau
2022-02-04  7:21     ` Siarhei Volkau [this message]
2022-02-04 11:05     ` Paul Cercueil
2022-02-04 18:22       ` Siarhei Volkau
2022-02-04 20:47         ` Paul Cercueil
2022-02-05  9:45           ` [PATCH v3 " Siarhei Volkau
2022-02-05  9:45             ` [PATCH v3 1/1] " Siarhei Volkau
2022-02-05  9:59               ` Greg KH
2022-02-05 12:15                 ` Paul Cercueil
2022-02-05 12:48                   ` Greg KH
2022-02-05 17:18                     ` [PATCH v4 0/1] " Siarhei Volkau
2022-02-05 17:18                       ` [PATCH v4 1/1] " Siarhei Volkau
2022-02-18  1:04                         ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220204072141.542909-2-lis8215@gmail.com \
    --to=lis8215@gmail.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=paul@crapouillou.net \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).