Re: [PATCH v9 1/4] drm/lsdc: add drm driver for loongson display controller

[kernel test robot <lkp@intel.com>]

Hi Sui,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm/drm-next]
[also build test WARNING on robh/for-next v5.17-rc4 next-20220217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sui-Jingfeng/drm-lsdc-add-drm-driver-for-loongson-display-controller/20220217-185718
base:   git://anongit.freedesktop.org/drm/drm drm-next
config: alpha-buildonly-randconfig-r001-20220217 (https://download.01.org/0day-ci/archive/20220217/202202172257.4uMfltD8-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/822d08dcd4408130e10897446cfdd640bcd53c8a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Sui-Jingfeng/drm-lsdc-add-drm-driver-for-loongson-display-controller/20220217-185718
        git checkout 822d08dcd4408130e10897446cfdd640bcd53c8a
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash drivers/gpu/drm/lsdc/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/lsdc/lsdc_plane.c: In function 'lsdc_cursor_atomic_disable':
>> drivers/gpu/drm/lsdc/lsdc_plane.c:420:26: warning: variable 'crtc' set but not used [-Wunused-but-set-variable]
     420 |         struct drm_crtc *crtc;
         |                          ^~~~


vim +/crtc +420 drivers/gpu/drm/lsdc/lsdc_plane.c

   413	
   414	static void lsdc_cursor_atomic_disable(struct drm_plane *plane,
   415					       struct drm_atomic_state *state)
   416	{
   417		struct drm_device *ddev = plane->dev;
   418		struct lsdc_device *ldev = to_lsdc(ddev);
   419		struct drm_plane_state *old_plane_state;
 > 420		struct drm_crtc *crtc;
   421	
   422		old_plane_state = drm_atomic_get_old_plane_state(state, plane);
   423	
   424		if (old_plane_state)
   425			crtc = old_plane_state->crtc;
   426	
   427		lsdc_reg_write32(ldev, LSDC_CURSOR_CFG_REG, 0);
   428	
   429		drm_dbg(ddev, "%s disabled\n", plane->name);
   430	}
   431	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org