linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: linux-clk@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Andreas Färber" <afaerber@suse.de>,
	"Saravanan Sekar" <sravanhome@gmail.com>,
	"Parthiban Nallathambi" <pn@denx.de>,
	linux-actions@lists.infradead.org
Subject: [PATCH v4 1/5] clk: actions: Terminate clk_div_table with sentinel element
Date: Fri, 18 Feb 2022 01:09:17 +0100	[thread overview]
Message-ID: <20220218000922.134857-2-j.neuschaefer@gmx.net> (raw)
In-Reply-To: <20220218000922.134857-1-j.neuschaefer@gmx.net>

In order that the end of a clk_div_table can be detected, it must be
terminated with a sentinel element (.div = 0).

In owl-s900.s, the { 0, 8 } element was probably meant to be just that,
so this patch changes { 0, 8 } to { 0, 0 }.

Fixes: d47317ca4ade1 ("clk: actions: Add S700 SoC clock support")
Fixes: d85d20053e195 ("clk: actions: Add S900 SoC clock support")
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
---

v4:
- Remove trailing commas

v3:
- Interpret { 0, 8 } as a typo of { 0, 0 }, the sentinel element
- Add R-b tag

v2:
- Add Fixes tags
---
 drivers/clk/actions/owl-s700.c | 1 +
 drivers/clk/actions/owl-s900.c | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/actions/owl-s700.c b/drivers/clk/actions/owl-s700.c
index a2f34d13fb543..6ea7da1d6d755 100644
--- a/drivers/clk/actions/owl-s700.c
+++ b/drivers/clk/actions/owl-s700.c
@@ -162,6 +162,7 @@ static struct clk_div_table hdmia_div_table[] = {

 static struct clk_div_table rmii_div_table[] = {
 	{0, 4},   {1, 10},
+	{0, 0}
 };

 /* divider clocks */
diff --git a/drivers/clk/actions/owl-s900.c b/drivers/clk/actions/owl-s900.c
index 790890978424a..5144ada2c7e1a 100644
--- a/drivers/clk/actions/owl-s900.c
+++ b/drivers/clk/actions/owl-s900.c
@@ -140,7 +140,7 @@ static struct clk_div_table rmii_ref_div_table[] = {

 static struct clk_div_table usb3_mac_div_table[] = {
 	{ 1, 2 }, { 2, 3 }, { 3, 4 },
-	{ 0, 8 },
+	{ 0, 0 }
 };

 static struct clk_div_table i2s_div_table[] = {
--
2.34.1


  reply	other threads:[~2022-02-18  0:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-18  0:09 [PATCH v4 0/5] clk drivers: Terminate clk_div_table with sentinel element Jonathan Neuschäfer
2022-02-18  0:09 ` Jonathan Neuschäfer [this message]
2022-03-12  2:16   ` [PATCH v4 1/5] clk: actions: " Stephen Boyd
2022-02-18  0:09 ` [PATCH v4 2/5] clk: loongson1: " Jonathan Neuschäfer
2022-03-12  2:16   ` Stephen Boyd
2022-02-18  0:09 ` [PATCH v4 3/5] clk: hisilicon: " Jonathan Neuschäfer
2022-03-12  2:16   ` Stephen Boyd
2022-02-18  0:09 ` [PATCH v4 4/5] clk: clps711x: " Jonathan Neuschäfer
2022-03-12  2:16   ` Stephen Boyd
2022-02-18  0:09 ` [PATCH v4 5/5] clk: actions: Make sentinel elements more obvious Jonathan Neuschäfer
2022-03-12  2:17   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220218000922.134857-2-j.neuschaefer@gmx.net \
    --to=j.neuschaefer@gmx.net \
    --cc=afaerber@suse.de \
    --cc=f4bug@amsat.org \
    --cc=linux-actions@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=pn@denx.de \
    --cc=sboyd@kernel.org \
    --cc=sravanhome@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).