* [PATCH] mips: setup: fix setnocoherentio() boolean setting
@ 2022-02-21 17:50 Randy Dunlap
2022-02-22 8:04 ` Christoph Hellwig
2022-02-22 8:43 ` Thomas Bogendoerfer
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2022-02-21 17:50 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Christoph Hellwig, Thomas Bogendoerfer, linux-mips
Correct a typo/pasto: setnocoherentio() should set
dma_default_coherent to false, not true.
Fixes: 14ac09a65e19 ("MIPS: refactor the runtime coherent vs noncoherent DMA indicators")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org
---
arch/mips/kernel/setup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20220217.orig/arch/mips/kernel/setup.c
+++ linux-next-20220217/arch/mips/kernel/setup.c
@@ -803,7 +803,7 @@ early_param("coherentio", setcoherentio)
static int __init setnocoherentio(char *str)
{
- dma_default_coherent = true;
+ dma_default_coherent = false;
pr_info("Software DMA cache coherency (command line)\n");
return 0;
}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mips: setup: fix setnocoherentio() boolean setting
2022-02-21 17:50 [PATCH] mips: setup: fix setnocoherentio() boolean setting Randy Dunlap
@ 2022-02-22 8:04 ` Christoph Hellwig
2022-02-22 8:43 ` Thomas Bogendoerfer
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2022-02-22 8:04 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Christoph Hellwig, Thomas Bogendoerfer, linux-mips
On Mon, Feb 21, 2022 at 09:50:29AM -0800, Randy Dunlap wrote:
> Correct a typo/pasto: setnocoherentio() should set
> dma_default_coherent to false, not true.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mips: setup: fix setnocoherentio() boolean setting
2022-02-21 17:50 [PATCH] mips: setup: fix setnocoherentio() boolean setting Randy Dunlap
2022-02-22 8:04 ` Christoph Hellwig
@ 2022-02-22 8:43 ` Thomas Bogendoerfer
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Bogendoerfer @ 2022-02-22 8:43 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, Christoph Hellwig, linux-mips
On Mon, Feb 21, 2022 at 09:50:29AM -0800, Randy Dunlap wrote:
> Correct a typo/pasto: setnocoherentio() should set
> dma_default_coherent to false, not true.
>
> Fixes: 14ac09a65e19 ("MIPS: refactor the runtime coherent vs noncoherent DMA indicators")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: linux-mips@vger.kernel.org
> ---
> arch/mips/kernel/setup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20220217.orig/arch/mips/kernel/setup.c
> +++ linux-next-20220217/arch/mips/kernel/setup.c
> @@ -803,7 +803,7 @@ early_param("coherentio", setcoherentio)
>
> static int __init setnocoherentio(char *str)
> {
> - dma_default_coherent = true;
> + dma_default_coherent = false;
> pr_info("Software DMA cache coherency (command line)\n");
> return 0;
> }
applied to mips-fixes.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-22 8:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-21 17:50 [PATCH] mips: setup: fix setnocoherentio() boolean setting Randy Dunlap
2022-02-22 8:04 ` Christoph Hellwig
2022-02-22 8:43 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).