From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
linux-mips@vger.kernel.org
Subject: Re: [PATCH] mips: setup: fix setnocoherentio() boolean setting
Date: Tue, 22 Feb 2022 09:43:31 +0100 [thread overview]
Message-ID: <20220222084331.GA7049@alpha.franken.de> (raw)
In-Reply-To: <20220221175029.6046-1-rdunlap@infradead.org>
On Mon, Feb 21, 2022 at 09:50:29AM -0800, Randy Dunlap wrote:
> Correct a typo/pasto: setnocoherentio() should set
> dma_default_coherent to false, not true.
>
> Fixes: 14ac09a65e19 ("MIPS: refactor the runtime coherent vs noncoherent DMA indicators")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: linux-mips@vger.kernel.org
> ---
> arch/mips/kernel/setup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20220217.orig/arch/mips/kernel/setup.c
> +++ linux-next-20220217/arch/mips/kernel/setup.c
> @@ -803,7 +803,7 @@ early_param("coherentio", setcoherentio)
>
> static int __init setnocoherentio(char *str)
> {
> - dma_default_coherent = true;
> + dma_default_coherent = false;
> pr_info("Software DMA cache coherency (command line)\n");
> return 0;
> }
applied to mips-fixes.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2022-02-22 8:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 17:50 [PATCH] mips: setup: fix setnocoherentio() boolean setting Randy Dunlap
2022-02-22 8:04 ` Christoph Hellwig
2022-02-22 8:43 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220222084331.GA7049@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).