* [PATCH V3] tty: serial: bcm63xx: use more precise Kconfig symbol
@ 2022-03-11 9:32 Rafał Miłecki
2022-03-11 9:43 ` Geert Uytterhoeven
2022-03-11 20:30 ` Florian Fainelli
0 siblings, 2 replies; 3+ messages in thread
From: Rafał Miłecki @ 2022-03-11 9:32 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Jiri Slaby, linux-serial, Florian Fainelli, linux-arm-kernel,
linux-mips, bcm-kernel-feedback-list, linux-kernel,
Rafał Miłecki, Geert Uytterhoeven
From: Rafał Miłecki <rafal@milecki.pl>
Patches lowering SERIAL_BCM63XX dependencies led to a discussion and
documentation change regarding "depends" usage. Adjust Kconfig entry to
match current guidelines. Make this symbol available for relevant
architectures only.
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Ref: f35a07f92616 ("tty: serial: bcm63xx: lower driver dependencies")
Ref: 18084e435ff6 ("Documentation/kbuild: Document platform dependency practises")
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
V2: Use precise "depends" (exact platforms)
V3: Don't default y for COMPILE_TEST
---
drivers/tty/serial/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index e952ec5c7a7c..b51341678b8a 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -1100,7 +1100,8 @@ config SERIAL_TIMBERDALE
config SERIAL_BCM63XX
tristate "Broadcom BCM63xx/BCM33xx UART support"
select SERIAL_CORE
- depends on COMMON_CLK
+ depends on ARCH_BCM4908 || ARCH_BCM_63XX || BCM63XX || BMIPS_GENERIC || COMPILE_TEST
+ default ARCH_BCM4908 || ARCH_BCM_63XX || BCM63XX || BMIPS_GENERIC
help
This enables the driver for the onchip UART core found on
the following chipsets:
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH V3] tty: serial: bcm63xx: use more precise Kconfig symbol
2022-03-11 9:32 [PATCH V3] tty: serial: bcm63xx: use more precise Kconfig symbol Rafał Miłecki
@ 2022-03-11 9:43 ` Geert Uytterhoeven
2022-03-11 20:30 ` Florian Fainelli
1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2022-03-11 9:43 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Greg Kroah-Hartman, Jiri Slaby, open list:SERIAL DRIVERS,
Florian Fainelli, Linux ARM, open list:BROADCOM NVRAM DRIVER,
bcm-kernel-feedback-list, Linux Kernel Mailing List,
Rafał Miłecki
Hi Rafał,
On Fri, Mar 11, 2022 at 10:32 AM Rafał Miłecki <zajec5@gmail.com> wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> Patches lowering SERIAL_BCM63XX dependencies led to a discussion and
> documentation change regarding "depends" usage. Adjust Kconfig entry to
> match current guidelines. Make this symbol available for relevant
> architectures only.
>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Ref: f35a07f92616 ("tty: serial: bcm63xx: lower driver dependencies")
> Ref: 18084e435ff6 ("Documentation/kbuild: Document platform dependency practises")
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> V2: Use precise "depends" (exact platforms)
> V3: Don't default y for COMPILE_TEST
Thanks for the update!
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1100,7 +1100,8 @@ config SERIAL_TIMBERDALE
> config SERIAL_BCM63XX
> tristate "Broadcom BCM63xx/BCM33xx UART support"
> select SERIAL_CORE
> - depends on COMMON_CLK
> + depends on ARCH_BCM4908 || ARCH_BCM_63XX || BCM63XX || BMIPS_GENERIC || COMPILE_TEST
> + default ARCH_BCM4908 || ARCH_BCM_63XX || BCM63XX || BMIPS_GENERIC
I'm still not convinced about the default, as it wasn't there before,
hence all existing config files must already have it.
But if the BCM people think it's good to have, I'll shut up ;-)
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> help
> This enables the driver for the onchip UART core found on
> the following chipsets:
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH V3] tty: serial: bcm63xx: use more precise Kconfig symbol
2022-03-11 9:32 [PATCH V3] tty: serial: bcm63xx: use more precise Kconfig symbol Rafał Miłecki
2022-03-11 9:43 ` Geert Uytterhoeven
@ 2022-03-11 20:30 ` Florian Fainelli
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2022-03-11 20:30 UTC (permalink / raw)
To: Rafał Miłecki, Greg Kroah-Hartman
Cc: Jiri Slaby, linux-serial, linux-arm-kernel, linux-mips,
bcm-kernel-feedback-list, linux-kernel, Rafał Miłecki,
Geert Uytterhoeven
On 3/11/22 1:32 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> Patches lowering SERIAL_BCM63XX dependencies led to a discussion and
> documentation change regarding "depends" usage. Adjust Kconfig entry to
> match current guidelines. Make this symbol available for relevant
> architectures only.
>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Ref: f35a07f92616 ("tty: serial: bcm63xx: lower driver dependencies")
> Ref: 18084e435ff6 ("Documentation/kbuild: Document platform dependency practises")
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-11 20:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-11 9:32 [PATCH V3] tty: serial: bcm63xx: use more precise Kconfig symbol Rafał Miłecki
2022-03-11 9:43 ` Geert Uytterhoeven
2022-03-11 20:30 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).