From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B157C433EF for ; Tue, 15 Mar 2022 18:09:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350985AbiCOSLG (ORCPT ); Tue, 15 Mar 2022 14:11:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350858AbiCOSLF (ORCPT ); Tue, 15 Mar 2022 14:11:05 -0400 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE1E559A77 for ; Tue, 15 Mar 2022 11:09:52 -0700 (PDT) Received: by mail-pl1-x631.google.com with SMTP id w8so962663pll.10 for ; Tue, 15 Mar 2022 11:09:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LnfhahHm3PDL9lPgihcYM1ixyCrpxkRE4I19AMm+GpI=; b=JVFkFjRzXHvl4p6lzecOm3qCuwJkQk5Aq/4Fikfk7weWrbtXCItQc1wAZya5H6IJDG QNI3GLzgvk3q2YYFCgId9Id3a/AMxyHSRXjdwlpHsKqaZesf5hk2QTOeNe8E421h+niV 56QoMW3xTldNTC6XDzfuHu9lXtWAK74IHih4w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LnfhahHm3PDL9lPgihcYM1ixyCrpxkRE4I19AMm+GpI=; b=isK5BJ0hVKBlI4wEgVThff9Ac4a6gdp/6B53HM+uR09xmDZgintMG4e1kJrSuyABp9 PVGXI19y002bN1bePBQE5fjJv8SnqCqJvb5+ZsVH9Tpips5tUudt8jrC9NBYnDeH8Mno MMOi6UXLkc3Kot6sbOodKjV50Xg+VWfylV3hBzP08BUdW384UL44CL0e6O0qRbEnBlfA oxaYLYUHfrRhJOVI1KCfofVL5iwmRgft9tflbF17lH/CFfg41r6Gb3FCvc6MdkGe2GdT DvpT8dRucDVh6+VWLv2Q9m3n1IqpMzJQr2mKuRCSYAzE6xNlfncmRBksxV4upNMy1K5Y ceHw== X-Gm-Message-State: AOAM5314DydR+6XO+KxvunBl1zBYN3lST2swhqGAV/vFHE5/thv9urqd 3p1ieZFBa3PJrnXR/UgNhlIuPw== X-Google-Smtp-Source: ABdhPJxrv8JWlmC583Lem9EnnxkdYf2cpc2Vr67JCGAwKnCX6HsrocM0D0dZOBLboyTP/eYhDYcA9Q== X-Received: by 2002:a17:90a:17ab:b0:1bf:9519:fe86 with SMTP id q40-20020a17090a17ab00b001bf9519fe86mr6027447pja.25.1647367792246; Tue, 15 Mar 2022 11:09:52 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 16-20020a17090a19d000b001c1c6b25cb2sm3736609pjj.26.2022.03.15.11.09.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Mar 2022 11:09:51 -0700 (PDT) Date: Tue, 15 Mar 2022 11:09:51 -0700 From: Kees Cook To: Thomas Bogendoerfer Cc: Nathan Chancellor , Marc Zyngier , Guenter Roeck , Yanteng Si , linux-mips@vger.kernel.org, Nick Desaulniers , Mark Rutland , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org Subject: Re: [PATCH v2] MIPS: Only use current_stack_pointer on GCC Message-ID: <202203151109.F59911C4CB@keescook> References: <20220309220939.392227-1-keescook@chromium.org> <20220314145215.GD13438@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220314145215.GD13438@alpha.franken.de> Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Mon, Mar 14, 2022 at 03:52:15PM +0100, Thomas Bogendoerfer wrote: > On Wed, Mar 09, 2022 at 02:09:39PM -0800, Kees Cook wrote: > > Unfortunately, Clang did not have support for "sp" as a global register > > definition, and was crashing after the addition of current_stack_pointer. > > This has been fixed in Clang 15, but earlier Clang versions need to > > avoid this code, so add a versioned test and revert back to the > > open-coded asm instances. Fixes Clang build error: > > > > fatal error: error in backend: Invalid register name global variable > > > > Fixes: 200ed341b864 ("mips: Implement "current_stack_pointer"") > > Reported-by: Nathan Chancellor > > Reviewed-by: Nathan Chancellor > > Link: https://lore.kernel.org/lkml/YikTQRql+il3HbrK@dev-arch.thelio-3990X > > Cc: Thomas Bogendoerfer > > Cc: Marc Zyngier > > Cc: Guenter Roeck > > Cc: Yanteng Si > > Cc: linux-mips@vger.kernel.org > > Signed-off-by: Kees Cook > > --- > > v1: https://lore.kernel.org/lkml/20220309204537.390428-1-keescook@chromium.org > > v2: - adjust Clang version (Nathan) > > --- > > arch/mips/Kconfig | 2 +- > > arch/mips/include/asm/thread_info.h | 2 ++ > > arch/mips/kernel/irq.c | 3 ++- > > arch/mips/lib/uncached.c | 4 +++- > > 4 files changed, 8 insertions(+), 3 deletions(-) > > applied to mips-next with the Clang version in the decscription fixed. Excellent; thanks very much! -Kees -- Kees Cook