From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70BB5C433EF for ; Wed, 30 Mar 2022 19:00:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349994AbiC3TCN (ORCPT ); Wed, 30 Mar 2022 15:02:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350285AbiC3TCM (ORCPT ); Wed, 30 Mar 2022 15:02:12 -0400 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 63E49267B for ; Wed, 30 Mar 2022 12:00:26 -0700 (PDT) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1nZdYO-0003Qd-02; Wed, 30 Mar 2022 21:00:24 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 8758EC4DEF; Wed, 30 Mar 2022 20:35:23 +0200 (CEST) Date: Wed, 30 Mar 2022 20:35:23 +0200 From: Thomas Bogendoerfer To: Jackie Liu Cc: linus.walleij@linaro.org, ralf@linux-mips.org, linux-mips@vger.kernel.org, jic23@kernel.org, andy.shevchenko@gmail.com, sergei.shtylyov@gmail.com Subject: Re: [PATCH v4] MIPS: rb532: move GPIOD definition into C-files Message-ID: <20220330183523.GC18042@alpha.franken.de> References: <20220330120921.1920941-1-liu.yun@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220330120921.1920941-1-liu.yun@linux.dev> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Wed, Mar 30, 2022 at 08:09:21PM +0800, Jackie Liu wrote: > From: Jackie Liu > > My kernel robot reports build error from drivers/iio/adc/da9150-gpadc.c, > > drivers/iio/adc/da9150-gpadc.c:254:13: error: ‘DA9150_GPADC_CHAN_0x08’ > undeclared here (not in a function); did you mean ‘DA9150_GPADC_CHAN_TBAT’? > 254 | .channel = DA9150_GPADC_CHAN_##_id, > > We define GPIOD in rb.h, in fact it should only be used in gpio.c, but > it affects the driver da9150-gpadc.c which goes against the original > intention of the design, just move it to its scope. > > Fixes: 1b432840d0a4 ("MIPS: RB532: GPIO register offsets are relative to GPIOBASE") > Suggested-by: Jonathan Cameron > Suggested-by: Andy Shevchenko > Reported-by: k2ci > Signed-off-by: Jackie Liu applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]