From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
arnd@arndb.de
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
Theodore Ts'o <tytso@mit.edu>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
"David S . Miller" <davem@davemloft.net>,
Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Johannes Berg <johannes@sipsolutions.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H . Peter Anvin" <hpa@zytor.com>,
Chris Zankel <chris@zankel.net>,
Max Filippov <jcmvbkbc@gmail.com>,
John Stultz <john.stultz@linaro.org>,
Stephen Boyd <sboyd@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
linux-riscv@lists.infradead.org, sparclinux@vger.kernel.org,
linux-um@lists.infradead.org, x86@kernel.org,
linux-xtensa@linux-xtensa.org
Subject: [PATCH RFC v1 07/10] arm64: use sched_clock() for random_get_entropy() instead of zero
Date: Fri, 8 Apr 2022 20:21:42 +0200 [thread overview]
Message-ID: <20220408182145.142506-8-Jason@zx2c4.com> (raw)
In-Reply-To: <20220408182145.142506-1-Jason@zx2c4.com>
In the event that random_get_entropy() can't access a cycle counter or
similar, falling back to returning 0 is really not the best we can do.
Instead, at least calling sched_clock() would be preferable, because
that always needs to return _something_, even falling back to jiffies
eventually. It's not as though sched_clock() is super high precision or
guaranteed to be entropic, but basically anything that's not zero all
the time is better than returning zero all the time.
If CONFIG_ARM_ARCH_TIMER=n, then get_cycles() will return 0, so we only
need the fallback code for that case.
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
arch/arm64/include/asm/timex.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/include/asm/timex.h b/arch/arm64/include/asm/timex.h
index cf59ce91b22d..bfebd2e1ce45 100644
--- a/arch/arm64/include/asm/timex.h
+++ b/arch/arm64/include/asm/timex.h
@@ -13,6 +13,15 @@
*/
#define get_cycles() arch_timer_read_counter()
+#ifndef CONFIG_ARM_ARCH_TIMER
+/*
+ * The default implementation of random_get_entropy() calls get_cycles(),
+ * which will return 0 if CONFIG_ARM_ARCH_TIMER=n, so we fall back to
+ * sched_clock() here. Not a great situation, but better than nothing.
+ */
+#define random_get_entropy() ((unsigned long)sched_clock())
+#endif
+
#include <asm-generic/timex.h>
#endif
--
2.35.1
next prev parent reply other threads:[~2022-04-08 18:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 18:21 [PATCH RFC v1 00/10] archs/random: fallback to using sched_clock() if no cycle counter Jason A. Donenfeld
2022-04-08 18:21 ` [PATCH RFC v1 01/10] random: use sched_clock() for random_get_entropy() if no get_cycles() Jason A. Donenfeld
2022-04-08 18:21 ` [PATCH RFC v1 02/10] m68k: use sched_clock() for random_get_entropy() instead of zero Jason A. Donenfeld
2022-04-08 18:21 ` [PATCH RFC v1 03/10] riscv: " Jason A. Donenfeld
2022-04-08 18:21 ` [PATCH RFC v1 04/10] mips: " Jason A. Donenfeld
2022-04-08 18:21 ` [PATCH RFC v1 05/10] arm: " Jason A. Donenfeld
2022-04-08 18:21 ` [PATCH RFC v1 06/10] x86: " Jason A. Donenfeld
2022-04-08 18:21 ` Jason A. Donenfeld [this message]
2022-04-08 18:33 ` [PATCH RFC v1 07/10] arm64: " Mark Rutland
2022-04-08 18:40 ` Jason A. Donenfeld
2022-04-08 18:21 ` [PATCH RFC v1 08/10] um: " Jason A. Donenfeld
2022-04-08 18:21 ` [PATCH RFC v1 09/10] sparc: " Jason A. Donenfeld
2022-04-08 18:21 ` [PATCH RFC v1 10/10] xtensa: " Jason A. Donenfeld
2022-04-09 23:29 ` [PATCH RFC v1 00/10] archs/random: fallback to using sched_clock() if no cycle counter Thomas Gleixner
2022-04-10 14:25 ` Jason A. Donenfeld
2022-04-10 20:57 ` Thomas Gleixner
2022-04-10 21:38 ` Jason A. Donenfeld
2022-04-10 23:03 ` Eric Biggers
2022-04-10 23:29 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220408182145.142506-8-Jason@zx2c4.com \
--to=jason@zx2c4.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chris@zankel.net \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=hpa@zytor.com \
--cc=jcmvbkbc@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-um@lists.infradead.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linux@armlinux.org.uk \
--cc=linux@dominikbrodowski.net \
--cc=mingo@redhat.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=richard@nod.at \
--cc=sboyd@kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=tytso@mit.edu \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).