* [PATCH 1/1] mips: cpc: Fix refcount leak in mips_cpc_default_phys_base
@ 2022-04-07 4:26 Yuanjun Gong
2022-04-12 13:05 ` Serge Semin
2022-04-26 14:32 ` Thomas Bogendoerfer
0 siblings, 2 replies; 3+ messages in thread
From: Yuanjun Gong @ 2022-04-07 4:26 UTC (permalink / raw)
To: Yuanjun Gong, Florian Fainelli, linux-mips, linux-kernel
From: Gong Yuanjun <ruc_gongyuanjun@163.com>
Add the missing of_node_put() to release the refcount incremented
by of_find_compatible_node().
Signed-off-by: Gong Yuanjun <ruc_gongyuanjun@163.com>
---
arch/mips/kernel/mips-cpc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mips/kernel/mips-cpc.c b/arch/mips/kernel/mips-cpc.c
index 17aff13cd7ce..3e386f7e1545 100644
--- a/arch/mips/kernel/mips-cpc.c
+++ b/arch/mips/kernel/mips-cpc.c
@@ -28,6 +28,7 @@ phys_addr_t __weak mips_cpc_default_phys_base(void)
cpc_node = of_find_compatible_node(of_root, NULL, "mti,mips-cpc");
if (cpc_node) {
err = of_address_to_resource(cpc_node, 0, &res);
+ of_node_put(cpc_node);
if (!err)
return res.start;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] mips: cpc: Fix refcount leak in mips_cpc_default_phys_base
2022-04-07 4:26 [PATCH 1/1] mips: cpc: Fix refcount leak in mips_cpc_default_phys_base Yuanjun Gong
@ 2022-04-12 13:05 ` Serge Semin
2022-04-26 14:32 ` Thomas Bogendoerfer
1 sibling, 0 replies; 3+ messages in thread
From: Serge Semin @ 2022-04-12 13:05 UTC (permalink / raw)
To: Yuanjun Gong, Thomas Bogendoerfer
Cc: Serge Semin, Florian Fainelli, linux-mips, linux-kernel
To += @Thomas
On Thu, Apr 07, 2022 at 12:26:57PM +0800, Yuanjun Gong wrote:
> From: Gong Yuanjun <ruc_gongyuanjun@163.com>
>
> Add the missing of_node_put() to release the refcount incremented
> by of_find_compatible_node().
Right, the same bug was fixed in the CDMM driver:
https://lore.kernel.org/linux-mips/20220309091711.3850-1-linmq006@gmail.com/
Good catch. Thanks.
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
-Sergey
>
> Signed-off-by: Gong Yuanjun <ruc_gongyuanjun@163.com>
> ---
> arch/mips/kernel/mips-cpc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/kernel/mips-cpc.c b/arch/mips/kernel/mips-cpc.c
> index 17aff13cd7ce..3e386f7e1545 100644
> --- a/arch/mips/kernel/mips-cpc.c
> +++ b/arch/mips/kernel/mips-cpc.c
> @@ -28,6 +28,7 @@ phys_addr_t __weak mips_cpc_default_phys_base(void)
> cpc_node = of_find_compatible_node(of_root, NULL, "mti,mips-cpc");
> if (cpc_node) {
> err = of_address_to_resource(cpc_node, 0, &res);
> + of_node_put(cpc_node);
> if (!err)
> return res.start;
> }
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] mips: cpc: Fix refcount leak in mips_cpc_default_phys_base
2022-04-07 4:26 [PATCH 1/1] mips: cpc: Fix refcount leak in mips_cpc_default_phys_base Yuanjun Gong
2022-04-12 13:05 ` Serge Semin
@ 2022-04-26 14:32 ` Thomas Bogendoerfer
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Bogendoerfer @ 2022-04-26 14:32 UTC (permalink / raw)
To: Yuanjun Gong; +Cc: Florian Fainelli, linux-mips, linux-kernel
On Thu, Apr 07, 2022 at 12:26:57PM +0800, Yuanjun Gong wrote:
> From: Gong Yuanjun <ruc_gongyuanjun@163.com>
>
> Add the missing of_node_put() to release the refcount incremented
> by of_find_compatible_node().
>
> Signed-off-by: Gong Yuanjun <ruc_gongyuanjun@163.com>
> ---
> arch/mips/kernel/mips-cpc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/kernel/mips-cpc.c b/arch/mips/kernel/mips-cpc.c
> index 17aff13cd7ce..3e386f7e1545 100644
> --- a/arch/mips/kernel/mips-cpc.c
> +++ b/arch/mips/kernel/mips-cpc.c
> @@ -28,6 +28,7 @@ phys_addr_t __weak mips_cpc_default_phys_base(void)
> cpc_node = of_find_compatible_node(of_root, NULL, "mti,mips-cpc");
> if (cpc_node) {
> err = of_address_to_resource(cpc_node, 0, &res);
> + of_node_put(cpc_node);
> if (!err)
> return res.start;
> }
> --
> 2.17.1
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-26 14:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-07 4:26 [PATCH 1/1] mips: cpc: Fix refcount leak in mips_cpc_default_phys_base Yuanjun Gong
2022-04-12 13:05 ` Serge Semin
2022-04-26 14:32 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).