From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Genjian Zhang <zhanggenjian123@gmail.com>
Cc: maz@kernel.org, keescook@chromium.org, mark.rutland@arm.com,
nathan@kernel.org, siyanteng01@gmail.com, yyuasa@linux.com,
ralf@linux-mips.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org, huhai@kylinos.cn,
k2ci <kernel-bot@kylinos.cn>
Subject: Re: [PATCH] irq: mips: Export irq_err_count to modules
Date: Mon, 23 May 2022 11:16:07 +0200 [thread overview]
Message-ID: <20220523091607.GA5069@alpha.franken.de> (raw)
In-Reply-To: <20220523081625.2074527-1-zhanggenjian@kylinos.cn>
On Mon, May 23, 2022 at 04:16:25PM +0800, Genjian Zhang wrote:
> From: huhai <huhai@kylinos.cn>
>
> modpost complains once these drivers become modules.
> ERROR: modpost: "irq_err_count" [drivers/gpio/gpio-vr41xx.ko] undefined!
>
> Fix it by export them when that symbol is =m.
>
> Fixes: 27fdd325dace ("MIPS: Update VR41xx GPIO driver to use gpiolib")
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Signed-off-by: huhai <huhai@kylinos.cn>
> ---
> arch/mips/kernel/irq.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/mips/kernel/irq.c b/arch/mips/kernel/irq.c
> index 5e11582fe308..b0038b715008 100644
> --- a/arch/mips/kernel/irq.c
> +++ b/arch/mips/kernel/irq.c
> @@ -38,6 +38,9 @@ void ack_bad_irq(unsigned int irq)
> }
>
> atomic_t irq_err_count;
> +#ifdef CONFIG_GPIO_VR41XX_MODULE
> +EXPORT_SYMBOL_GPL(irq_err_count);
> +#endif
please use spurious_interrupt() in drivers/gpio/gpio-vr41xx.c.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2022-05-23 9:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 8:16 [PATCH] irq: mips: Export irq_err_count to modules Genjian Zhang
2022-05-23 9:16 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220523091607.GA5069@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=huhai@kylinos.cn \
--cc=keescook@chromium.org \
--cc=kernel-bot@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=nathan@kernel.org \
--cc=ralf@linux-mips.org \
--cc=siyanteng01@gmail.com \
--cc=yyuasa@linux.com \
--cc=zhanggenjian123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).