From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CD26CCA482 for ; Sat, 11 Jun 2022 14:13:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234957AbiFKONw (ORCPT ); Sat, 11 Jun 2022 10:13:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234947AbiFKONd (ORCPT ); Sat, 11 Jun 2022 10:13:33 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A39F564D25; Sat, 11 Jun 2022 07:13:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 72ACEB80B78; Sat, 11 Jun 2022 14:13:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A775DC34116; Sat, 11 Jun 2022 14:13:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654956804; bh=nyZvL91oFCb9bthQSadgYmYYNFgPdHqKzIod7PSvXoE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=C2tuo46TtbrdY2D19m2dgc8qWZXkB9kD9XOOUf+g2P6r7or/YShlN3zfieoRbi1Vk mRI7PO6xQMBBZDFZ33JtIn/6IVQn/VTxVQXaJO1ADbDwlQfv3ugfoK+SZ2wWPnkBEe NQN0YnkPwxplxSwb5TPXK7nCa4EcaM5XEQsCru/WIGnRxSEQ5MOC6fJr8zRFIfBTyu tLwN+T41I7UHRhABICFeESgCC5Pk7w7sag45jDCofg7ENDt7w2JsMMV2UnrL0YRNvo 0EPVDiII3hAp7sPmFQsLP0zYudeuY2ortQ78I2x55E+QAmRNr9FxfNDMWR9mLxN2JJ ED2zAMUfpL0uQ== Date: Sat, 11 Jun 2022 15:22:22 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: Nuno =?UTF-8?B?U8Oh?= , dl-linux-imx , Linux-Renesas , "open list:BROADCOM NVRAM DRIVER" , linux-arm Mailing List , chrome-platform@lists.linux.dev, Lad Prabhakar , "moderated list:ARM/Mediatek SoC support" , linux-stm32@st-md-mailman.stormreply.com, linux-arm-msm , linux-iio , OpenBMC Maillist , Cai Huoqing , Benjamin Fair , Jishnu Prakash , Linus Walleij , Lars-Peter Clausen , Alexandre Torgue , Amit Kucheria , Andy Gross , Michael Hennerich , Haibo Chen , Benson Leung , "Rafael J. Wysocki" , Alexandre Belloni , Christophe Branchereau , Patrick Venture , Arnd Bergmann , Nancy Yuen , Sascha Hauer , Daniel Lezcano , Gwendal Grignou , Saravanan Sekar , Tali Perry , Maxime Coquelin , Paul Cercueil , Thara Gopinath , Avi Fishman , Lorenzo Bianconi , Claudiu Beznea , Pengutronix Kernel Team , Fabrice Gasnier , Matthias Brugger , Tomer Maimon , Bjorn Andersson , Nicolas Ferre , Zhang Rui , Shawn Guo , Guenter Roeck , Fabio Estevam , Olivier Moysan , Eugen Hristev , Miquel Raynal Subject: Re: [PATCH 15/34] iio: humidity: hts221_buffer: explicitly add proper header files Message-ID: <20220611152222.43ab685e@jic23-huawei> In-Reply-To: References: <20220610084545.547700-1-nuno.sa@analog.com> <20220610084545.547700-16-nuno.sa@analog.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Fri, 10 Jun 2022 16:47:16 +0200 Andy Shevchenko wrote: > On Fri, Jun 10, 2022 at 10:47 AM Nuno S=C3=A1 wrote: > > > > Do not trust the fact that iio.h includes of.h which in turn includes > > all the headers we are relying on. > > > > The ultimate goal is to actually drop of.h from iio.h. =20 >=20 > ... >=20 > > #include > > #include > > #include > > +#include =20 >=20 > Yes, I see, but you can make life easier if you try to squeeze to the > most sorted part. I do not see full context, but here I would put it > before regmap.h. >=20 With full context it's clear the list is way off sorted, but meh putting it above regmap probably reduces the follow up diff a tiny bit and I doubt Nuno feels strongly about this so I went with what Andy suggested as a tweak whilst applying. Applied Thanks, Jonathan